diff mbox series

[linux,dev-5.3,5/7] fsi: aspeed: Avoid copying read data twice

Message ID 20191025010351.30298-6-joel@jms.id.au
State Accepted, archived
Headers show
Series AST2600 FSI speed improvements | expand

Commit Message

Joel Stanley Oct. 25, 2019, 1:03 a.m. UTC 
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
 drivers/fsi/fsi-master-aspeed.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Andrew Jeffery Oct. 25, 2019, 2:09 a.m. UTC | #1 
On Fri, 25 Oct 2019, at 12:03, Joel Stanley wrote:
> Signed-off-by: Joel Stanley <joel@jms.id.au>

Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
diff mbox series

Patch

diff --git a/drivers/fsi/fsi-master-aspeed.c b/drivers/fsi/fsi-master-aspeed.c
index 58b090e2cf46..c98b1bf179a8 100644
--- a/drivers/fsi/fsi-master-aspeed.c
+++ b/drivers/fsi/fsi-master-aspeed.c
@@ -303,20 +303,17 @@  static int aspeed_master_read(struct fsi_master *master, int link,
 {
 	struct fsi_master_aspeed *aspeed = to_fsi_master_aspeed(master);
 	int ret;
-	u32 data;
 
 	if (id != 0)
 		return -EINVAL;
 
 	addr += link * FSI_HUB_LINK_SIZE;
-	ret = opb_read(aspeed->base, fsi_base + addr, size, &data);
+	ret = opb_read(aspeed->base, fsi_base + addr, size, val);
 
 	ret = check_errors(aspeed, ret);
 	if (ret)
 		return ret;
 
-	memcpy(val, &data, size);
-
 	return 0;
 }