| Message ID | 20190708024749.22039-1-joel@jms.id.au |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [linux,dev-5.2] ARM: dts: aspeed: Remove mbox node from device tree | expand |
On Mon, 8 Jul 2019, at 12:18, Joel Stanley wrote: > This device driver was never upstreamed and so it has been dropped from > the tree. Remove the node from systems that had it enabled. > > Signed-off-by: Joel Stanley <joel@jms.id.au> Acked-by: Andrew Jeffery <andrew@aj.id.au> > --- > arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts | 4 ---- > arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts | 4 ---- > arch/arm/boot/dts/aspeed-bmc-opp-swift.dts | 4 ---- > 3 files changed, 12 deletions(-) > > diff --git a/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts > b/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts > index c762c02dc716..628195b66d46 100644 > --- a/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts > +++ b/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts > @@ -235,10 +235,6 @@ > flash = <&spi1>; > }; > > -&mbox { > - status = "okay"; > -}; > - > &mac0 { > status = "okay"; > pinctrl-names = "default"; > diff --git a/arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts > b/arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts > index a3d6b71518fc..73319917cb74 100644 > --- a/arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts > +++ b/arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts > @@ -163,10 +163,6 @@ > status = "okay"; > }; > > -&mbox { > - status = "okay"; > -}; > - > &pwm_tacho { > status = "okay"; > pinctrl-names = "default"; > diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts > b/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts > index 270c9236deff..caac895c60b4 100644 > --- a/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts > +++ b/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts > @@ -317,10 +317,6 @@ > flash = <&spi1>; > }; > > -&mbox { > - status = "okay"; > -}; > - > &mac0 { > status = "okay"; > pinctrl-names = "default"; > -- > 2.20.1 > >
On 2019-07-07 21:47, Joel Stanley wrote: > This device driver was never upstreamed and so it has been dropped from > the tree. Remove the node from systems that had it enabled. Seems there are other systems that have it enabled, like witherspoon, palmetto, zaius, and lanyang, should this be removed from their tree as well? > > Signed-off-by: Joel Stanley <joel@jms.id.au> > --- > arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts | 4 ---- > arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts | 4 ---- > arch/arm/boot/dts/aspeed-bmc-opp-swift.dts | 4 ---- > 3 files changed, 12 deletions(-) > > diff --git a/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts > b/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts > index c762c02dc716..628195b66d46 100644 > --- a/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts > +++ b/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts > @@ -235,10 +235,6 @@ > flash = <&spi1>; > }; > > -&mbox { > - status = "okay"; > -}; > - > &mac0 { > status = "okay"; > pinctrl-names = "default"; > diff --git a/arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts > b/arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts > index a3d6b71518fc..73319917cb74 100644 > --- a/arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts > +++ b/arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts > @@ -163,10 +163,6 @@ > status = "okay"; > }; > > -&mbox { > - status = "okay"; > -}; > - > &pwm_tacho { > status = "okay"; > pinctrl-names = "default"; > diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts > b/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts > index 270c9236deff..caac895c60b4 100644 > --- a/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts > +++ b/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts > @@ -317,10 +317,6 @@ > flash = <&spi1>; > }; > > -&mbox { > - status = "okay"; > -}; > - > &mac0 { > status = "okay"; > pinctrl-names = "default";
On Tue, 9 Jul 2019 at 21:02, Adriana Kobylak <anoo@linux.ibm.com> wrote: > > On 2019-07-07 21:47, Joel Stanley wrote: > > This device driver was never upstreamed and so it has been dropped from > > the tree. Remove the node from systems that had it enabled. > > Seems there are other systems that have it enabled, like witherspoon, > palmetto, zaius, and lanyang, should this be removed from their tree as > well? Thanks for taking a close look. The systems I remove it from in this patch are ones that enabled it in the patch that adds the device tree. Others had it enabled in a separate patch, which I dropped from dev-5.2. Cheers, Joel > > > > > Signed-off-by: Joel Stanley <joel@jms.id.au> > > --- > > arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts | 4 ---- > > arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts | 4 ---- > > arch/arm/boot/dts/aspeed-bmc-opp-swift.dts | 4 ---- > > 3 files changed, 12 deletions(-) > > > > diff --git a/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts > > b/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts > > index c762c02dc716..628195b66d46 100644 > > --- a/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts > > +++ b/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts > > @@ -235,10 +235,6 @@ > > flash = <&spi1>; > > }; > > > > -&mbox { > > - status = "okay"; > > -}; > > - > > &mac0 { > > status = "okay"; > > pinctrl-names = "default"; > > diff --git a/arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts > > b/arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts > > index a3d6b71518fc..73319917cb74 100644 > > --- a/arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts > > +++ b/arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts > > @@ -163,10 +163,6 @@ > > status = "okay"; > > }; > > > > -&mbox { > > - status = "okay"; > > -}; > > - > > &pwm_tacho { > > status = "okay"; > > pinctrl-names = "default"; > > diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts > > b/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts > > index 270c9236deff..caac895c60b4 100644 > > --- a/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts > > +++ b/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts > > @@ -317,10 +317,6 @@ > > flash = <&spi1>; > > }; > > > > -&mbox { > > - status = "okay"; > > -}; > > - > > &mac0 { > > status = "okay"; > > pinctrl-names = "default"; >
On 2019-07-08 19:03, Andrew Jeffery wrote: > On Mon, 8 Jul 2019, at 12:18, Joel Stanley wrote: >> This device driver was never upstreamed and so it has been dropped >> from >> the tree. Remove the node from systems that had it enabled. >> >> Signed-off-by: Joel Stanley <joel@jms.id.au> > > Acked-by: Andrew Jeffery <andrew@aj.id.au> > Acked-by: Adriana Kobylak <anoo@us.ibm.com> >> --- >> arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts | 4 ---- >> arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts | 4 ---- >> arch/arm/boot/dts/aspeed-bmc-opp-swift.dts | 4 ---- >> 3 files changed, 12 deletions(-) >> >> diff --git a/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts >> b/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts >> index c762c02dc716..628195b66d46 100644 >> --- a/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts >> +++ b/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts >> @@ -235,10 +235,6 @@ >> flash = <&spi1>; >> }; >> >> -&mbox { >> - status = "okay"; >> -}; >> - >> &mac0 { >> status = "okay"; >> pinctrl-names = "default"; >> diff --git a/arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts >> b/arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts >> index a3d6b71518fc..73319917cb74 100644 >> --- a/arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts >> +++ b/arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts >> @@ -163,10 +163,6 @@ >> status = "okay"; >> }; >> >> -&mbox { >> - status = "okay"; >> -}; >> - >> &pwm_tacho { >> status = "okay"; >> pinctrl-names = "default"; >> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts >> b/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts >> index 270c9236deff..caac895c60b4 100644 >> --- a/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts >> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts >> @@ -317,10 +317,6 @@ >> flash = <&spi1>; >> }; >> >> -&mbox { >> - status = "okay"; >> -}; >> - >> &mac0 { >> status = "okay"; >> pinctrl-names = "default"; >> -- >> 2.20.1 >> >>
diff --git a/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts b/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts index c762c02dc716..628195b66d46 100644 --- a/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts +++ b/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts @@ -235,10 +235,6 @@ flash = <&spi1>; }; -&mbox { - status = "okay"; -}; - &mac0 { status = "okay"; pinctrl-names = "default"; diff --git a/arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts b/arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts index a3d6b71518fc..73319917cb74 100644 --- a/arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts +++ b/arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts @@ -163,10 +163,6 @@ status = "okay"; }; -&mbox { - status = "okay"; -}; - &pwm_tacho { status = "okay"; pinctrl-names = "default"; diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts b/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts index 270c9236deff..caac895c60b4 100644 --- a/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts +++ b/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts @@ -317,10 +317,6 @@ flash = <&spi1>; }; -&mbox { - status = "okay"; -}; - &mac0 { status = "okay"; pinctrl-names = "default";
This device driver was never upstreamed and so it has been dropped from the tree. Remove the node from systems that had it enabled. Signed-off-by: Joel Stanley <joel@jms.id.au> --- arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts | 4 ---- arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts | 4 ---- arch/arm/boot/dts/aspeed-bmc-opp-swift.dts | 4 ---- 3 files changed, 12 deletions(-)