diff mbox

[v2] ARM: dts: witherspoon: add Epson RX8900CE RTC module

Message ID 20161026065509.GA10287@distroguy.com
State Accepted, archived
Headers show

Commit Message

Chris Smart Oct. 26, 2016, 6:55 a.m. UTC
This commit adds the relevant device tree entry for the Epson RX8900CE
RTC module on the I2C bus.

Note that there are two options that we may need to set.

If there is no connected battery:
 epson,vdet-disable;

If there is no trickle charge diode:
 epson,vdet-disable;

These are currently left commented out in the commit.

Signed-off-by: Chris Smart <chris@distroguy.com>
---

Changes since v1:
	- fixed up the entry for rtc@32

 arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 12 ++++++++++++
 1 file changed, 12 insertions(+)

Comments

Joel Stanley Oct. 27, 2016, 12:18 a.m. UTC | #1
Hey Chris,

On Wed, Oct 26, 2016 at 5:25 PM, Chris Smart <chris@distroguy.com> wrote:
>         /* RTC */
> +       rtc@32 {
> +               compatible = "epson,rx8900"
> +               reg = <0x32>;

Did you try building this?

Cheers,

Joel
Chris Smart Oct. 27, 2016, 12:42 a.m. UTC | #2
On Thu, Oct 27, 2016 at 10:48:01AM +1030, Joel Stanley wrote:
>Hey Chris,
>
>On Wed, Oct 26, 2016 at 5:25 PM, Chris Smart <chris@distroguy.com> wrote:
>>         /* RTC */
>> +       rtc@32 {
>> +               compatible = "epson,rx8900"
>> +               reg = <0x32>;
>
>Did you try building this?
>

My bad, v3 incoming.

-c
diff mbox

Patch

diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
index 328a9c4e189e..19a91a207530 100644
--- a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
@@ -148,7 +148,19 @@ 
 
 	/* TPM */
 	/* 9552 */
+
 	/* RTC */
+	rtc@32 {
+		compatible = "epson,rx8900"
+		reg = <0x32>;
+		/*
+		 * If no battery, set this:
+		 * epson,vdet-disable;
+		 * If no trickle charge diode, set this:
+		 * epson,vdet-disable;
+		 */
+	};
+
 	/* EEPROM */
 
 	eeprom@51 {