| Message ID | 1553196610-29595-8-git-send-email-eajames@linux.ibm.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Enable video engine | expand |
On Thu, 21 Mar 2019 at 19:30, Eddie James <eajames@linux.ibm.com> wrote: > > Enable the video engine and set it's required memory-region property. > > Signed-off-by: Eddie James <eajames@linux.ibm.com> > --- > arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts > index ee1a460..6b24608 100644 > --- a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts > +++ b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts > @@ -37,7 +37,7 @@ > }; > > gfx_memory: framebuffer { > - size = <0x01000000>; > + size = <0x04000000>; You're using the memory region we have set aside for the gfx device - the thing that you plug a monitor into the back of a machine with. Are you sure that is what we want to do? > alignment = <0x01000000>; > compatible = "shared-dma-pool"; > reusable; > @@ -315,4 +315,9 @@ > memory-region = <&gfx_memory>; > }; > > +&video { > + status = "okay"; > + memory-region = <&gfx_memory>; > +}; > + > #include "ibm-power9-dual.dtsi" > -- > 1.8.3.1 >
On 3/27/19 1:11 AM, Joel Stanley wrote: > On Thu, 21 Mar 2019 at 19:30, Eddie James <eajames@linux.ibm.com> wrote: >> Enable the video engine and set it's required memory-region property. >> >> Signed-off-by: Eddie James <eajames@linux.ibm.com> >> --- >> arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts >> index ee1a460..6b24608 100644 >> --- a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts >> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts >> @@ -37,7 +37,7 @@ >> }; >> >> gfx_memory: framebuffer { >> - size = <0x01000000>; >> + size = <0x04000000>; > You're using the memory region we have set aside for the gfx device - > the thing that you plug a monitor into the back of a machine with. Are > you sure that is what we want to do? It still has to be allocated in the kernel, right? I'm assuming that the kernel won't give memory areas we've grabbed with the gfx driver to the video driver, and same in reverse. I could add a separate memory region too, this just seemed convenient. > >> alignment = <0x01000000>; >> compatible = "shared-dma-pool"; >> reusable; >> @@ -315,4 +315,9 @@ >> memory-region = <&gfx_memory>; >> }; >> >> +&video { >> + status = "okay"; >> + memory-region = <&gfx_memory>; >> +}; >> + >> #include "ibm-power9-dual.dtsi" >> -- >> 1.8.3.1 >>
On Thu, 28 Mar 2019, at 01:37, Eddie James wrote: > > On 3/27/19 1:11 AM, Joel Stanley wrote: > > On Thu, 21 Mar 2019 at 19:30, Eddie James <eajames@linux.ibm.com> wrote: > >> Enable the video engine and set it's required memory-region property. > >> > >> Signed-off-by: Eddie James <eajames@linux.ibm.com> > >> --- > >> arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts | 7 ++++++- > >> 1 file changed, 6 insertions(+), 1 deletion(-) > >> > >> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts > >> index ee1a460..6b24608 100644 > >> --- a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts > >> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts > >> @@ -37,7 +37,7 @@ > >> }; > >> > >> gfx_memory: framebuffer { > >> - size = <0x01000000>; > >> + size = <0x04000000>; > > You're using the memory region we have set aside for the gfx device - > > the thing that you plug a monitor into the back of a machine with. Are > > you sure that is what we want to do? > > It still has to be allocated in the kernel, right? I'm assuming that the > kernel won't give memory areas we've grabbed with the gfx driver to the > video driver, and same in reverse. I could add a separate memory region > too, this just seemed convenient. Lets go with a new node. > > > > >> alignment = <0x01000000>; > >> compatible = "shared-dma-pool"; > >> reusable; > >> @@ -315,4 +315,9 @@ > >> memory-region = <&gfx_memory>; > >> }; > >> > >> +&video { > >> + status = "okay"; > >> + memory-region = <&gfx_memory>; > >> +}; > >> + > >> #include "ibm-power9-dual.dtsi" > >> -- > >> 1.8.3.1 > >> > >
diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts index ee1a460..6b24608 100644 --- a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts +++ b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts @@ -37,7 +37,7 @@ }; gfx_memory: framebuffer { - size = <0x01000000>; + size = <0x04000000>; alignment = <0x01000000>; compatible = "shared-dma-pool"; reusable; @@ -315,4 +315,9 @@ memory-region = <&gfx_memory>; }; +&video { + status = "okay"; + memory-region = <&gfx_memory>; +}; + #include "ibm-power9-dual.dtsi"
Enable the video engine and set it's required memory-region property. Signed-off-by: Eddie James <eajames@linux.ibm.com> --- arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)