mbox series

[u-boot,v2019.04-aspeed-openbmc,v2,0/2] Store default u-boot env in

Message ID 20210621064102.961633-1-joel@jms.id.au
Headers show
Series Store default u-boot env in | expand

Message

Joel Stanley June 21, 2021, 6:41 a.m. UTC 
This patch adds the u-boot environment to the u-boot binary, and a build
fix for the new configuration that I have also sent upstream.

v2 uses the latest boot commands from openbmc.

We currently rely on the default environment being populated in the
image. This has the downside that if something corrupts the environment,
the system won't know how to boot itself.

The ast2600_openbmc_mmc.txt is copied from
meta-aspeed/recipes-bsp/u-boot/files/u-boot-env-ast2600.txt.

Adriana has indicated she will update openbmc to use the .txt from the
u-boot tree to generate the filesystem image (or we could stop doing
that, and simply use the default?).

Joel Stanley (2):
  Makefile: Conditionally add defaultenv_h to envtools target
  ast2600: Add environment for booting from mmc

 Makefile                                   |  2 ++
 board/aspeed/ast2600_openbmc_mmc.txt       | 11 +++++++++++
 configs/ast2600_openbmc_spl_emmc_defconfig |  2 ++
 3 files changed, 15 insertions(+)
 create mode 100644 board/aspeed/ast2600_openbmc_mmc.txt

Comments

Graeme Gregory July 8, 2021, 10:26 a.m. UTC | #1 
On Mon, Jun 21, 2021 at 04:11:00PM +0930, Joel Stanley wrote:
> 
> This patch adds the u-boot environment to the u-boot binary, and a build
> fix for the new configuration that I have also sent upstream.
> 
> v2 uses the latest boot commands from openbmc.
> 
> We currently rely on the default environment being populated in the
> image. This has the downside that if something corrupts the environment,
> the system won't know how to boot itself.
> 
> The ast2600_openbmc_mmc.txt is copied from
> meta-aspeed/recipes-bsp/u-boot/files/u-boot-env-ast2600.txt.
> 

Just a note because I just stumbled on this, when these commits hit
OpenBMC there will need to be an xxd-native package added as xxd is
a build requirement for this.

Graeme

> Adriana has indicated she will update openbmc to use the .txt from the
> u-boot tree to generate the filesystem image (or we could stop doing
> that, and simply use the default?).
> 
> Joel Stanley (2):
>   Makefile: Conditionally add defaultenv_h to envtools target
>   ast2600: Add environment for booting from mmc
> 
>  Makefile                                   |  2 ++
>  board/aspeed/ast2600_openbmc_mmc.txt       | 11 +++++++++++
>  configs/ast2600_openbmc_spl_emmc_defconfig |  2 ++
>  3 files changed, 15 insertions(+)
>  create mode 100644 board/aspeed/ast2600_openbmc_mmc.txt
> 
> -- 
> 2.32.0
>