mbox series

[v3,0/3] add ast2400/2500 phy-handle support

Message ID 20201030133707.12099-1-i.mikhaylov@yadro.com
Headers show
Series add ast2400/2500 phy-handle support | expand

Message

Ivan Mikhaylov Oct. 30, 2020, 1:37 p.m. UTC
This patch introduces ast2400/2500 phy-handle support with an embedded
MDIO controller. At the current moment it is not possible to set options
with this format on ast2400/2500:

mac {
	phy-handle = <&phy>;
	phy-mode = "rgmii";

	mdio {
		#address-cells = <1>;
		#size-cells = <0>;

		phy: ethernet-phy@0 {
			compatible = "ethernet-phy-idxxxx.yyyy";
			reg = <0>;
		};
	};
};

The patch fixes it and gets possible PHYs and register them with
of_mdiobus_register.

Changes from v3:
   1. add dt-bindings description of MDIO node and phy-handle option
      with example.

Changes from v2:
   1. change manual phy interface type check on phy_interface_mode_is_rgmii
      function.
   2. add err_phy_connect label.
   3. split ftgmac100_destroy_mdio into ftgmac100_phy_disconnect and
      ftgmac100_destroy_mdio.
   4. remove unneeded mdio_np checks.

Changes from v1:
   1. split one patch into two.

Ivan Mikhaylov (3):
  net: ftgmac100: move phy connect out from ftgmac100_setup_mdio
  net: ftgmac100: add handling of mdio/phy nodes for ast2400/2500
  dt-bindings: net: ftgmac100: describe phy-handle and MDIO

 .../devicetree/bindings/net/ftgmac100.txt     |  25 ++++
 drivers/net/ethernet/faraday/ftgmac100.c      | 122 ++++++++++--------
 2 files changed, 96 insertions(+), 51 deletions(-)

Comments

Jakub Kicinski Nov. 2, 2020, 11:14 p.m. UTC | #1
On Fri, 30 Oct 2020 16:37:04 +0300 Ivan Mikhaylov wrote:
> This patch introduces ast2400/2500 phy-handle support with an embedded
> MDIO controller. At the current moment it is not possible to set options
> with this format on ast2400/2500:
> 
> mac {
> 	phy-handle = <&phy>;
> 	phy-mode = "rgmii";
> 
> 	mdio {
> 		#address-cells = <1>;
> 		#size-cells = <0>;
> 
> 		phy: ethernet-phy@0 {
> 			compatible = "ethernet-phy-idxxxx.yyyy";
> 			reg = <0>;
> 		};
> 	};
> };
> 
> The patch fixes it and gets possible PHYs and register them with
> of_mdiobus_register.

Applied, thanks!