| Message ID | 1531812378-14316-1-git-send-email-ryanchen.aspeed@gmail.com |
|---|---|
| Headers | show |
| Series | mmc/host: Add Aspeed SDIO driver | expand |
On Tue, 2018-07-17 at 15:26 +0800, Ryan Chen wrote: > This series implements Aspeed SDIO driver. In Aspeed SDIO controller > with two slots and have a global register for interrupt status and other > general information. > > v2 > Change irqchip driver(irq-aspeed-sdhci-ic.c) to aspeed sdhci core driver > aspeed-sdhci-core.c Thanks, that's much better I think. Cheers, Ben. > > v0 > For implements this, it will have have irq-aspeed-sdhci-ic.c for sdhci > each slot irq dispatch, and then go to sdhci driver handle (sdhci.c). > > Another is sdhci-of-aspeed.c for specific function call. > > > Ryan Chen > > > Ryan Chen (7): > clk: Aspeed: Modify clk-aspeed.c driver probe sequence > clk: Aspeed: Add sdhci reset and clock > mmc: Aspeed: Add Aspeed sdhci core driver > mmc: Aspeed: Add driver for Aspeed sdhci > dts: Aspeed: Add devicetree for Aspeed sdhci > Documentation: mmc: add aspeed sdhci binding document > configs: Aspeed: enable mmc host in defconfig > > .../bindings/mmc/aspeed,aspeed-sdhci.txt | 54 +++++++ > arch/arm/boot/dts/aspeed-ast2500-evb.dts | 14 ++ > arch/arm/boot/dts/aspeed-g4.dtsi | 40 +++++ > arch/arm/boot/dts/aspeed-g5.dtsi | 40 +++++ > arch/arm/configs/aspeed_g5_defconfig | 6 + > drivers/clk/clk-aspeed.c | 51 +++--- > drivers/irqchip/Makefile | 2 +- > drivers/mmc/host/Kconfig | 12 ++ > drivers/mmc/host/Makefile | 1 + > drivers/mmc/host/aspeed-sdhci-core.c | 147 +++++++++++++++++ > drivers/mmc/host/sdhci-of-aspeed.c | 178 +++++++++++++++++++++ > include/dt-bindings/clock/aspeed-clock.h | 2 +- > include/linux/mmc/sdhci-aspeed-data.h | 28 ++++ > 13 files changed, 553 insertions(+), 22 deletions(-) > create mode 100644 Documentation/devicetree/bindings/mmc/aspeed,aspeed-sdhci.txt > create mode 100644 drivers/mmc/host/aspeed-sdhci-core.c > create mode 100644 drivers/mmc/host/sdhci-of-aspeed.c > create mode 100644 include/linux/mmc/sdhci-aspeed-data.h >
Guys, what's the fate of this patch set? Is going to be merged into openbmc linux? We have an SD card slot on our BMC card and so would like to know whether or not to await arrival of SDIO support from upstream or import this patch set locally. Thank you. 17.07.2018 10:26, Ryan Chen wrote: > This series implements Aspeed SDIO driver. In Aspeed SDIO controller > with two slots and have a global register for interrupt status and other > general information. > > v2 > Change irqchip driver(irq-aspeed-sdhci-ic.c) to aspeed sdhci core driver > aspeed-sdhci-core.c > > v0 > For implements this, it will have have irq-aspeed-sdhci-ic.c for sdhci > each slot irq dispatch, and then go to sdhci driver handle (sdhci.c). > > Another is sdhci-of-aspeed.c for specific function call. > > > Ryan Chen > > > Ryan Chen (7): > clk: Aspeed: Modify clk-aspeed.c driver probe sequence > clk: Aspeed: Add sdhci reset and clock > mmc: Aspeed: Add Aspeed sdhci core driver > mmc: Aspeed: Add driver for Aspeed sdhci > dts: Aspeed: Add devicetree for Aspeed sdhci > Documentation: mmc: add aspeed sdhci binding document > configs: Aspeed: enable mmc host in defconfig > > .../bindings/mmc/aspeed,aspeed-sdhci.txt | 54 +++++++ > arch/arm/boot/dts/aspeed-ast2500-evb.dts | 14 ++ > arch/arm/boot/dts/aspeed-g4.dtsi | 40 +++++ > arch/arm/boot/dts/aspeed-g5.dtsi | 40 +++++ > arch/arm/configs/aspeed_g5_defconfig | 6 + > drivers/clk/clk-aspeed.c | 51 +++--- > drivers/irqchip/Makefile | 2 +- > drivers/mmc/host/Kconfig | 12 ++ > drivers/mmc/host/Makefile | 1 + > drivers/mmc/host/aspeed-sdhci-core.c | 147 +++++++++++++++++ > drivers/mmc/host/sdhci-of-aspeed.c | 178 +++++++++++++++++++++ > include/dt-bindings/clock/aspeed-clock.h | 2 +- > include/linux/mmc/sdhci-aspeed-data.h | 28 ++++ > 13 files changed, 553 insertions(+), 22 deletions(-) > create mode 100644 Documentation/devicetree/bindings/mmc/aspeed,aspeed-sdhci.txt > create mode 100644 drivers/mmc/host/aspeed-sdhci-core.c > create mode 100644 drivers/mmc/host/sdhci-of-aspeed.c > create mode 100644 include/linux/mmc/sdhci-aspeed-data.h >
Hello, I got some feedback from maintainer. I will modify for new architecture, hopeful, I will apply new patch at March. Rayn -----Original Message----- From: openbmc [mailto:openbmc-bounces+ryan_chen=aspeedtech.com@lists.ozlabs.org] On Behalf Of Alexander Amelkin Sent: Friday, February 15, 2019 6:36 PM To: openbmc@lists.ozlabs.org Subject: Re: [PATCHv2 linux dev-4.17 0/7] mmc/host: Add Aspeed SDIO driver Guys, what's the fate of this patch set? Is going to be merged into openbmc linux? We have an SD card slot on our BMC card and so would like to know whether or not to await arrival of SDIO support from upstream or import this patch set locally. Thank you. 17.07.2018 10:26, Ryan Chen wrote: > This series implements Aspeed SDIO driver. In Aspeed SDIO controller > with two slots and have a global register for interrupt status and > other general information. > > v2 > Change irqchip driver(irq-aspeed-sdhci-ic.c) to aspeed sdhci core > driver aspeed-sdhci-core.c > > v0 > For implements this, it will have have irq-aspeed-sdhci-ic.c for sdhci > each slot irq dispatch, and then go to sdhci driver handle (sdhci.c). > > Another is sdhci-of-aspeed.c for specific function call. > > > Ryan Chen > > > Ryan Chen (7): > clk: Aspeed: Modify clk-aspeed.c driver probe sequence > clk: Aspeed: Add sdhci reset and clock > mmc: Aspeed: Add Aspeed sdhci core driver > mmc: Aspeed: Add driver for Aspeed sdhci > dts: Aspeed: Add devicetree for Aspeed sdhci > Documentation: mmc: add aspeed sdhci binding document > configs: Aspeed: enable mmc host in defconfig > > .../bindings/mmc/aspeed,aspeed-sdhci.txt | 54 +++++++ > arch/arm/boot/dts/aspeed-ast2500-evb.dts | 14 ++ > arch/arm/boot/dts/aspeed-g4.dtsi | 40 +++++ > arch/arm/boot/dts/aspeed-g5.dtsi | 40 +++++ > arch/arm/configs/aspeed_g5_defconfig | 6 + > drivers/clk/clk-aspeed.c | 51 +++--- > drivers/irqchip/Makefile | 2 +- > drivers/mmc/host/Kconfig | 12 ++ > drivers/mmc/host/Makefile | 1 + > drivers/mmc/host/aspeed-sdhci-core.c | 147 +++++++++++++++++ > drivers/mmc/host/sdhci-of-aspeed.c | 178 +++++++++++++++++++++ > include/dt-bindings/clock/aspeed-clock.h | 2 +- > include/linux/mmc/sdhci-aspeed-data.h | 28 ++++ > 13 files changed, 553 insertions(+), 22 deletions(-) create mode > 100644 Documentation/devicetree/bindings/mmc/aspeed,aspeed-sdhci.txt > create mode 100644 drivers/mmc/host/aspeed-sdhci-core.c > create mode 100644 drivers/mmc/host/sdhci-of-aspeed.c > create mode 100644 include/linux/mmc/sdhci-aspeed-data.h >
Hi, Ryan! How is it going? We've tried the original version of your patch and it didn't apply for us due to a typo. We've fixed the typo, but it still doesn't work. We're not sure yet why. Have you verified that old patch on any real hardware? When do you think you'll be able to come up with the new version of the patch? Thank you. Alexander. 16.02.2019 9:20, Ryan Chen wrote: > Hello, > I got some feedback from maintainer. I will modify for new architecture, hopeful, I will apply new patch at March. > > Rayn > > -----Original Message----- > From: openbmc [mailto:openbmc-bounces+ryan_chen=aspeedtech.com@lists.ozlabs.org] On Behalf Of Alexander Amelkin > Sent: Friday, February 15, 2019 6:36 PM > To: openbmc@lists.ozlabs.org > Subject: Re: [PATCHv2 linux dev-4.17 0/7] mmc/host: Add Aspeed SDIO driver > > Guys, what's the fate of this patch set? > Is going to be merged into openbmc linux? > We have an SD card slot on our BMC card and so would like to know whether or not to await arrival of SDIO support from upstream or import this patch set locally. > > Thank you. > > 17.07.2018 10:26, Ryan Chen wrote: >> This series implements Aspeed SDIO driver. In Aspeed SDIO controller >> with two slots and have a global register for interrupt status and >> other general information. >> >> v2 >> Change irqchip driver(irq-aspeed-sdhci-ic.c) to aspeed sdhci core >> driver aspeed-sdhci-core.c >> >> v0 >> For implements this, it will have have irq-aspeed-sdhci-ic.c for sdhci >> each slot irq dispatch, and then go to sdhci driver handle (sdhci.c). >> >> Another is sdhci-of-aspeed.c for specific function call. >> >> >> Ryan Chen >> >> >> Ryan Chen (7): >> clk: Aspeed: Modify clk-aspeed.c driver probe sequence >> clk: Aspeed: Add sdhci reset and clock >> mmc: Aspeed: Add Aspeed sdhci core driver >> mmc: Aspeed: Add driver for Aspeed sdhci >> dts: Aspeed: Add devicetree for Aspeed sdhci >> Documentation: mmc: add aspeed sdhci binding document >> configs: Aspeed: enable mmc host in defconfig >> >> .../bindings/mmc/aspeed,aspeed-sdhci.txt | 54 +++++++ >> arch/arm/boot/dts/aspeed-ast2500-evb.dts | 14 ++ >> arch/arm/boot/dts/aspeed-g4.dtsi | 40 +++++ >> arch/arm/boot/dts/aspeed-g5.dtsi | 40 +++++ >> arch/arm/configs/aspeed_g5_defconfig | 6 + >> drivers/clk/clk-aspeed.c | 51 +++--- >> drivers/irqchip/Makefile | 2 +- >> drivers/mmc/host/Kconfig | 12 ++ >> drivers/mmc/host/Makefile | 1 + >> drivers/mmc/host/aspeed-sdhci-core.c | 147 +++++++++++++++++ >> drivers/mmc/host/sdhci-of-aspeed.c | 178 +++++++++++++++++++++ >> include/dt-bindings/clock/aspeed-clock.h | 2 +- >> include/linux/mmc/sdhci-aspeed-data.h | 28 ++++ >> 13 files changed, 553 insertions(+), 22 deletions(-) create mode >> 100644 Documentation/devicetree/bindings/mmc/aspeed,aspeed-sdhci.txt >> create mode 100644 drivers/mmc/host/aspeed-sdhci-core.c >> create mode 100644 drivers/mmc/host/sdhci-of-aspeed.c >> create mode 100644 include/linux/mmc/sdhci-aspeed-data.h >>
Hello Alexander, The original version is patch on v4.17.4, it can build with the patch. Does there have any message? Currently I am ongoing on new version SOC chip also with new adhci, and will apply patch at June. Ryan >>How is it going? We've tried the original version of your patch and it didn't apply for us due to a typo. We've fixed the typo, but it still doesn't work. >>We're not sure yet why. Have you verified that old patch on any real hardware? When do you think you'll be able to come up with the new version of >>the patch? >>Thank you. >>Alexander. 16.02.2019 9:20, Ryan Chen wrote: > Hello, > I got some feedback from maintainer. I will modify for new architecture, hopeful, I will apply new patch at March. > > Rayn > > -----Original Message----- > From: openbmc > [mailto:openbmc-bounces+ryan_chen=aspeedtech.com@lists.ozlabs.org] On > Behalf Of Alexander Amelkin > Sent: Friday, February 15, 2019 6:36 PM > To: openbmc@lists.ozlabs.org > Subject: Re: [PATCHv2 linux dev-4.17 0/7] mmc/host: Add Aspeed SDIO > driver > > Guys, what's the fate of this patch set? > Is going to be merged into openbmc linux? > We have an SD card slot on our BMC card and so would like to know whether or not to await arrival of SDIO support from upstream or import this patch set locally. > > Thank you. > > 17.07.2018 10:26, Ryan Chen wrote: >> This series implements Aspeed SDIO driver. In Aspeed SDIO controller >> with two slots and have a global register for interrupt status and >> other general information. >> >> v2 >> Change irqchip driver(irq-aspeed-sdhci-ic.c) to aspeed sdhci core >> driver aspeed-sdhci-core.c >> >> v0 >> For implements this, it will have have irq-aspeed-sdhci-ic.c for >> sdhci each slot irq dispatch, and then go to sdhci driver handle (sdhci.c). >> >> Another is sdhci-of-aspeed.c for specific function call. >> >> >> Ryan Chen >> >> >> Ryan Chen (7): >> clk: Aspeed: Modify clk-aspeed.c driver probe sequence >> clk: Aspeed: Add sdhci reset and clock >> mmc: Aspeed: Add Aspeed sdhci core driver >> mmc: Aspeed: Add driver for Aspeed sdhci >> dts: Aspeed: Add devicetree for Aspeed sdhci >> Documentation: mmc: add aspeed sdhci binding document >> configs: Aspeed: enable mmc host in defconfig >> >> .../bindings/mmc/aspeed,aspeed-sdhci.txt | 54 +++++++ >> arch/arm/boot/dts/aspeed-ast2500-evb.dts | 14 ++ >> arch/arm/boot/dts/aspeed-g4.dtsi | 40 +++++ >> arch/arm/boot/dts/aspeed-g5.dtsi | 40 +++++ >> arch/arm/configs/aspeed_g5_defconfig | 6 + >> drivers/clk/clk-aspeed.c | 51 +++--- >> drivers/irqchip/Makefile | 2 +- >> drivers/mmc/host/Kconfig | 12 ++ >> drivers/mmc/host/Makefile | 1 + >> drivers/mmc/host/aspeed-sdhci-core.c | 147 +++++++++++++++++ >> drivers/mmc/host/sdhci-of-aspeed.c | 178 +++++++++++++++++++++ >> include/dt-bindings/clock/aspeed-clock.h | 2 +- >> include/linux/mmc/sdhci-aspeed-data.h | 28 ++++ >> 13 files changed, 553 insertions(+), 22 deletions(-) create mode >> 100644 Documentation/devicetree/bindings/mmc/aspeed,aspeed-sdhci.txt >> create mode 100644 drivers/mmc/host/aspeed-sdhci-core.c >> create mode 100644 drivers/mmc/host/sdhci-of-aspeed.c >> create mode 100644 include/linux/mmc/sdhci-aspeed-data.h >>
Thanks Ryan. After fixing a typo in your patch (ASPEED_CLK_GATE_SDCLKLK instead of ASPEED_CLK_GATE_SDCLK) and building the driver, we've found a minor hardware issue in our design that prevented the driver from working with our board. We've fixed it and it works for us now. Anyway, it would be great to see the driver upstreamed. Alexander. 13.03.2019 3:29, Ryan Chen wrote: > Hello Alexander, > The original version is patch on v4.17.4, it can build with the patch. Does there have any message? > Currently I am ongoing on new version SOC chip also with new adhci, and will apply patch at June. > Ryan > >>> How is it going? We've tried the original version of your patch and it didn't apply for us due to a typo. We've fixed the typo, but it still doesn't work. >>We're not sure yet why. Have you verified that old patch on any real hardware? When do you think you'll be able to come up with the new version of >>the patch? >>> Thank you. >>> Alexander. > 16.02.2019 9:20, Ryan Chen wrote: >> Hello, >> I got some feedback from maintainer. I will modify for new architecture, hopeful, I will apply new patch at March. >> >> Rayn >> >> -----Original Message----- >> From: openbmc >> [mailto:openbmc-bounces+ryan_chen=aspeedtech.com@lists.ozlabs.org] On >> Behalf Of Alexander Amelkin >> Sent: Friday, February 15, 2019 6:36 PM >> To: openbmc@lists.ozlabs.org >> Subject: Re: [PATCHv2 linux dev-4.17 0/7] mmc/host: Add Aspeed SDIO >> driver >> >> Guys, what's the fate of this patch set? >> Is going to be merged into openbmc linux? >> We have an SD card slot on our BMC card and so would like to know whether or not to await arrival of SDIO support from upstream or import this patch set locally. >> >> Thank you. >> >> 17.07.2018 10:26, Ryan Chen wrote: >>> This series implements Aspeed SDIO driver. In Aspeed SDIO controller >>> with two slots and have a global register for interrupt status and >>> other general information. >>> >>> v2 >>> Change irqchip driver(irq-aspeed-sdhci-ic.c) to aspeed sdhci core >>> driver aspeed-sdhci-core.c >>> >>> v0 >>> For implements this, it will have have irq-aspeed-sdhci-ic.c for >>> sdhci each slot irq dispatch, and then go to sdhci driver handle (sdhci.c). >>> >>> Another is sdhci-of-aspeed.c for specific function call. >>> >>> >>> Ryan Chen >>> >>> >>> Ryan Chen (7): >>> clk: Aspeed: Modify clk-aspeed.c driver probe sequence >>> clk: Aspeed: Add sdhci reset and clock >>> mmc: Aspeed: Add Aspeed sdhci core driver >>> mmc: Aspeed: Add driver for Aspeed sdhci >>> dts: Aspeed: Add devicetree for Aspeed sdhci >>> Documentation: mmc: add aspeed sdhci binding document >>> configs: Aspeed: enable mmc host in defconfig >>> >>> .../bindings/mmc/aspeed,aspeed-sdhci.txt | 54 +++++++ >>> arch/arm/boot/dts/aspeed-ast2500-evb.dts | 14 ++ >>> arch/arm/boot/dts/aspeed-g4.dtsi | 40 +++++ >>> arch/arm/boot/dts/aspeed-g5.dtsi | 40 +++++ >>> arch/arm/configs/aspeed_g5_defconfig | 6 + >>> drivers/clk/clk-aspeed.c | 51 +++--- >>> drivers/irqchip/Makefile | 2 +- >>> drivers/mmc/host/Kconfig | 12 ++ >>> drivers/mmc/host/Makefile | 1 + >>> drivers/mmc/host/aspeed-sdhci-core.c | 147 +++++++++++++++++ >>> drivers/mmc/host/sdhci-of-aspeed.c | 178 +++++++++++++++++++++ >>> include/dt-bindings/clock/aspeed-clock.h | 2 +- >>> include/linux/mmc/sdhci-aspeed-data.h | 28 ++++ >>> 13 files changed, 553 insertions(+), 22 deletions(-) create mode >>> 100644 Documentation/devicetree/bindings/mmc/aspeed,aspeed-sdhci.txt >>> create mode 100644 drivers/mmc/host/aspeed-sdhci-core.c >>> create mode 100644 drivers/mmc/host/sdhci-of-aspeed.c >>> create mode 100644 include/linux/mmc/sdhci-aspeed-data.h >>>
On Fri, 22 Mar 2019 at 23:00, Alexander Amelkin <a.amelkin@yadro.com> wrote: > After fixing a typo in your patch (ASPEED_CLK_GATE_SDCLKLK instead of ASPEED_CLK_GATE_SDCLK) and building the driver, > we've found a minor hardware issue in our design that prevented the driver from working with our board. > We've fixed it and it works for us now. Anyway, it would be great to see the driver upstreamed. We can apply it to the openbmc tree if that would help. I can't seem to find Ryan's v2. Alexander, if you want to post the version that you tested to the openbmc list I can apply that. Cheers, Joel