| Message ID | BD22328D0EB182418C2A0952DC2454F83F071BB8@VMPREVAS2.prevas.se |
|---|---|
| State | Superseded |
| Delegated to: | Esben Haabendal |
| Headers | show |
Kim Højgaard-Hansen <Kim.Hansen@prevas.dk> writes: > Hi Svend Aage, > > I think you mean "dupdate args" not "daemon args" in the commit msg? Me 2 :) > Also, could you describe why this is needed, what fails without it? Adding the possibility for overriding the default dupdate daemon cmdline arguments via USE flag is good enough for me. /Esben > > /Kim > ____________________________ > > ________________________________________ > Fra: dev-bounces@oe-lite.org [dev-bounces@oe-lite.org] på vegne af Svend Aage Vedstesen [Svend.Vedstesen@prevas.dk] > Sendt: 13. maj 2014 09:21 > Til: dev@oe-lite.org > Emne: [base] dupdate: add daemon args as useflag > > --- > recipes/dupdate/dupdate.inc | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/recipes/dupdate/dupdate.inc b/recipes/dupdate/dupdate.inc > index 4e781e9..c2c107b 100644 > --- a/recipes/dupdate/dupdate.inc > +++ b/recipes/dupdate/dupdate.inc > @@ -11,15 +11,21 @@ S = "${SRCDIR}/dupdate" > > inherit autotools > > -RECIPE_FLAGS += "dupdate_exefile" > +RECIPE_FLAGS += "dupdate_exefile dupdate_args" > include conf/dupdate.conf > DEFAULT_USE_dupdate_exefile ?= "run_update.sh" > +DEFAULT_USE_dupdate_args ?= "$DIR -x $EXEFILE -l" > > do_configure[postfuncs] =+ "do_configure_EXEFILE" > do_configure_EXEFILE() { > sed 's/^EXEFILE.*/EXEFILE="${USE_dupdate_exefile}"/' -i ${S}/src/dupdate.sh > } > > +do_configure[postfuncs] =+ "do_configure_ARGS" > +do_configure_ARGS() { > + sed 's/^ARGS.*/ARGS="${USE_dupdate_args}"/' -i ${S}/src/dupdate.sh > +} > + > INSTALL_SYSVINIT_POSTFUNC = "" > INSTALL_SYSVINIT_POSTFUNC:USE_sysvinit = "do_install_sysvinit_dupdate" > do_install[postfuncs] =+ "${INSTALL_SYSVINIT_POSTFUNC}"
Hi You are both correct. I have created a new patch request with this topic instead: [base] dupdate: add dupdate args as useflag Please ignore the current mail thread. /Svend -----Original Message----- From: Esben Haabendal [mailto:esben.haabendal@dev.prevas.dk] Sent: 13. maj 2014 09:57 To: Kim Højgaard-Hansen Cc: Svend Aage Vedstesen; dev@oe-lite.org Subject: Re: [base] dupdate: add daemon args as useflag Kim Højgaard-Hansen <Kim.Hansen@prevas.dk> writes: > Hi Svend Aage, > > I think you mean "dupdate args" not "daemon args" in the commit msg? Me 2 :) > Also, could you describe why this is needed, what fails without it? Adding the possibility for overriding the default dupdate daemon cmdline arguments via USE flag is good enough for me. /Esben > > /Kim > ____________________________ > > ________________________________________ > Fra: dev-bounces@oe-lite.org [dev-bounces@oe-lite.org] på vegne > af Svend Aage Vedstesen [Svend.Vedstesen@prevas.dk] > Sendt: 13. maj 2014 09:21 > Til: dev@oe-lite.org > Emne: [base] dupdate: add daemon args as useflag > > --- > recipes/dupdate/dupdate.inc | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/recipes/dupdate/dupdate.inc b/recipes/dupdate/dupdate.inc > index 4e781e9..c2c107b 100644 > --- a/recipes/dupdate/dupdate.inc > +++ b/recipes/dupdate/dupdate.inc > @@ -11,15 +11,21 @@ S = "${SRCDIR}/dupdate" > > inherit autotools > > -RECIPE_FLAGS += "dupdate_exefile" > +RECIPE_FLAGS += "dupdate_exefile dupdate_args" > include conf/dupdate.conf > DEFAULT_USE_dupdate_exefile ?= "run_update.sh" > +DEFAULT_USE_dupdate_args ?= "$DIR -x $EXEFILE -l" > > do_configure[postfuncs] =+ "do_configure_EXEFILE" > do_configure_EXEFILE() { > sed 's/^EXEFILE.*/EXEFILE="${USE_dupdate_exefile}"/' -i > ${S}/src/dupdate.sh } > > +do_configure[postfuncs] =+ "do_configure_ARGS" > +do_configure_ARGS() { > + sed 's/^ARGS.*/ARGS="${USE_dupdate_args}"/' -i > +${S}/src/dupdate.sh } > + > INSTALL_SYSVINIT_POSTFUNC = "" > INSTALL_SYSVINIT_POSTFUNC:USE_sysvinit = "do_install_sysvinit_dupdate" > do_install[postfuncs] =+ "${INSTALL_SYSVINIT_POSTFUNC}"
Merged to master, thanks. /Esben
diff --git a/recipes/dupdate/dupdate.inc b/recipes/dupdate/dupdate.inc index 4e781e9..c2c107b 100644 --- a/recipes/dupdate/dupdate.inc +++ b/recipes/dupdate/dupdate.inc @@ -11,15 +11,21 @@ S = "${SRCDIR}/dupdate" inherit autotools -RECIPE_FLAGS += "dupdate_exefile" +RECIPE_FLAGS += "dupdate_exefile dupdate_args" include conf/dupdate.conf DEFAULT_USE_dupdate_exefile ?= "run_update.sh" +DEFAULT_USE_dupdate_args ?= "$DIR -x $EXEFILE -l" do_configure[postfuncs] =+ "do_configure_EXEFILE" do_configure_EXEFILE() { sed 's/^EXEFILE.*/EXEFILE="${USE_dupdate_exefile}"/' -i ${S}/src/dupdate.sh } +do_configure[postfuncs] =+ "do_configure_ARGS" +do_configure_ARGS() { + sed 's/^ARGS.*/ARGS="${USE_dupdate_args}"/' -i ${S}/src/dupdate.sh +} + INSTALL_SYSVINIT_POSTFUNC = "" INSTALL_SYSVINIT_POSTFUNC:USE_sysvinit = "do_install_sysvinit_dupdate" do_install[postfuncs] =+ "${INSTALL_SYSVINIT_POSTFUNC}"