[base,1/8] nspr upgrade to 4.10.6.

---
 recipes/nspr/nspr_4.10.6.oe     | 59 +++++++++++++++++++++++++++++++++++++++++
 recipes/nspr/nspr_4.10.6.oe.sig |  1 +
 2 files changed, 60 insertions(+)
 create mode 100644 recipes/nspr/nspr_4.10.6.oe
 create mode 100644 recipes/nspr/nspr_4.10.6.oe.sig

Hi Mads



On 2014-08-07 14:53, Mads Doré wrote:
> ---
>   recipes/nspr/nspr_4.10.6.oe     | 59 +++++++++++++++++++++++++++++++++++++++++
>   recipes/nspr/nspr_4.10.6.oe.sig |  1 +
>   2 files changed, 60 insertions(+)
>   create mode 100644 recipes/nspr/nspr_4.10.6.oe
>   create mode 100644 recipes/nspr/nspr_4.10.6.oe.sig
>
> diff --git a/recipes/nspr/nspr_4.10.6.oe b/recipes/nspr/nspr_4.10.6.oe
> new file mode 100644
> index 0000000..a1a5dc3
> --- /dev/null
> +++ b/recipes/nspr/nspr_4.10.6.oe
> @@ -0,0 +1,59 @@
> +SUMMARY = "Netscape portable runtime, or NSPR, a platform abstraction library"
> +DESCRIPTION = """
> +NSPR, a platform abstraction library, makes all operating systems it supports
> +appear the same to (for example) Mozilla-style web-browsers. NSPR provides platform
> +independence for non-GUI operating system facilities
> +"""
> +HOMEPAGE = "https://developer.mozilla.org/docs/NSPR"
> +LICENSE = "MPL"
> +
> +RECIPE_TYPES = "machine native"
> +
> +SRC_URI = "ftp://ftp.mozilla.org/pub/mozilla.org/nspr/releases/v${PV}/src/${PN}-${PV}.tar.gz"
> +SRC_URI:>machine += " file://nsinstall.patch"
> +
> +inherit pkgconfig autotools auto-package-libs auto-package-utils
> +
> +DEPENDS += "libstdc++ libdl librt libpthread "
> +DEPENDS:>machine += " native:nspr-nsinstall"
> +
> +EXTRA_OECONF:>machine = ""
> +
> +EXTRA_OECONF += " \
> +	--enable-mdupdate \
> +	--enable-64bit \
> +"
> +
> +S = "${SRCDIR}/${PN}-${PV}/${PN}"
> +
> +NSINSTALL_POST_FUNC = ""
> +NSINSTALL_POST_FUNC:native = "do_install_nsinstall"
> +do_install[postfuncs] += "${NSINSTALL_POST_FUNC}"
> +do_install_nsinstall() {
> +	install -d ${D}/${bindir}
> +	install -m 0755 ${S}/config/nsinstall ${D}/${bindir}
> +}
> +
> +
> +
> +AUTO_PACKAGE_UTILS = "nspr-config nsinstall"
> +
> +FILES_${PN}-nspr-config += " ${bindir}/compile-et.pl "
> +FILES_${PN}-nspr-config += " ${bindir}/prerr.properties "
> +
> +AUTO_PACKAGE_UTILS_RDEPENDS += "${PN}"
> +
> +# This package only creates .so files. These are
> +# what we need in the 'main package'
> +SOLIBS = ".so"
> +SOLIBSDEV = ".so.*"
> +
> +AUTO_PACKAGE_LIBS = "nspr4 plc4 plds4"
> +AUTO_PACKAGE_LIB_RDEPENDS = "libpthread libdl librt libc"
> +
> +RDEPENDS_${PN} = "libnspr4 libplc4 libplds4"
> +
> +RDEPENDS_${PN}-plc4 = "libnspr4"
> +RDEPENDS_${PN}-plds4 = "libnspr4"
> +
> +DEPENDS_${PN} = "${LIBS_AUTO_PACKAGES}"
> diff --git a/recipes/nspr/nspr_4.10.6.oe.sig b/recipes/nspr/nspr_4.10.6.oe.sig
> new file mode 100644
> index 0000000..8aacd1c
> --- /dev/null
> +++ b/recipes/nspr/nspr_4.10.6.oe.sig
> @@ -0,0 +1 @@
> +9f3f278f7f31574b2cdbb99d9703c58e51cd3e1c  nspr-4.10.6.tar.gz
First of all;
When upgrading a recipe, please consider splitting the commonalities 
into a .inc file.. Makes it easier to spot the difference between the 
different versions, hereby making it easier to maintain.
It is quite hard to spot that you added "--enable-64bit" to 
EXTRA_OECONF, and that this was the only change you did, when you just 
copied the entire file instead of splitting it out.

Furthermore, remember to run packageqa on the recipe. It currently fails 
due to missing dependencies..

/Christian

Hi Mads,

Are you interested in doing the work required for this change? I have a more proper fix for the --enable-64bit flag, but in order to get a newer version in and make it maintainable it should be split as per christians suggestion.

Let me know if you want to do it, or I should pick it up instead.

Br,
Kim

Hi Kim,

Fixed and put on github - pull request sent.

Best regards
Mads

On 2014-12-15 09:35, Kim Højgaard-Hansen wrote:
> Hi Mads,
>
> Are you interested in doing the work required for this change? I have a more proper fix for the --enable-64bit flag, but in order to get a newer version in and make it maintainable it should be split as per christians suggestion.
>
> Let me know if you want to do it, or I should pick it up instead.
>
> Br,
> Kim
>
> ____________________________
> KIM HØJGAARD-HANSEN
> Software Developer
>
> Prevas A/S
> Hedeager 1
> DK-8200 Århus N
>
> Central +45 87438070
> Direct/Mobile +45 51547387
> kim.hansen@prevas.dk
> www.prevas.dk
> ________________________________________
> Fra: dev-bounces@oe-lite.org [dev-bounces@oe-lite.org] på vegne af "Christian B. Sørensen" [christian.braunersorensen@prevas.dk]
> Sendt: 19. august 2014 10:48
> Til: Mads Doré; dev@oe-lite.org
> Emne: Re: [base 1/8] nspr upgrade to 4.10.6.
>
> Hi Mads
>
>
>
> On 2014-08-07 14:53, Mads Doré wrote:
>> ---
>>    recipes/nspr/nspr_4.10.6.oe     | 59 +++++++++++++++++++++++++++++++++++++++++
>>    recipes/nspr/nspr_4.10.6.oe.sig |  1 +
>>    2 files changed, 60 insertions(+)
>>    create mode 100644 recipes/nspr/nspr_4.10.6.oe
>>    create mode 100644 recipes/nspr/nspr_4.10.6.oe.sig
>>
>> diff --git a/recipes/nspr/nspr_4.10.6.oe b/recipes/nspr/nspr_4.10.6.oe
>> new file mode 100644
>> index 0000000..a1a5dc3
>> --- /dev/null
>> +++ b/recipes/nspr/nspr_4.10.6.oe
>> @@ -0,0 +1,59 @@
>> +SUMMARY = "Netscape portable runtime, or NSPR, a platform abstraction library"
>> +DESCRIPTION = """
>> +NSPR, a platform abstraction library, makes all operating systems it supports
>> +appear the same to (for example) Mozilla-style web-browsers. NSPR provides platform
>> +independence for non-GUI operating system facilities
>> +"""
>> +HOMEPAGE = "https://developer.mozilla.org/docs/NSPR"
>> +LICENSE = "MPL"
>> +
>> +RECIPE_TYPES = "machine native"
>> +
>> +SRC_URI = "ftp://ftp.mozilla.org/pub/mozilla.org/nspr/releases/v${PV}/src/${PN}-${PV}.tar.gz"
>> +SRC_URI:>machine += " file://nsinstall.patch"
>> +
>> +inherit pkgconfig autotools auto-package-libs auto-package-utils
>> +
>> +DEPENDS += "libstdc++ libdl librt libpthread "
>> +DEPENDS:>machine += " native:nspr-nsinstall"
>> +
>> +EXTRA_OECONF:>machine = ""
>> +
>> +EXTRA_OECONF += " \
>> +     --enable-mdupdate \
>> +     --enable-64bit \
>> +"
>> +
>> +S = "${SRCDIR}/${PN}-${PV}/${PN}"
>> +
>> +NSINSTALL_POST_FUNC = ""
>> +NSINSTALL_POST_FUNC:native = "do_install_nsinstall"
>> +do_install[postfuncs] += "${NSINSTALL_POST_FUNC}"
>> +do_install_nsinstall() {
>> +     install -d ${D}/${bindir}
>> +     install -m 0755 ${S}/config/nsinstall ${D}/${bindir}
>> +}
>> +
>> +
>> +
>> +AUTO_PACKAGE_UTILS = "nspr-config nsinstall"
>> +
>> +FILES_${PN}-nspr-config += " ${bindir}/compile-et.pl "
>> +FILES_${PN}-nspr-config += " ${bindir}/prerr.properties "
>> +
>> +AUTO_PACKAGE_UTILS_RDEPENDS += "${PN}"
>> +
>> +# This package only creates .so files. These are
>> +# what we need in the 'main package'
>> +SOLIBS = ".so"
>> +SOLIBSDEV = ".so.*"
>> +
>> +AUTO_PACKAGE_LIBS = "nspr4 plc4 plds4"
>> +AUTO_PACKAGE_LIB_RDEPENDS = "libpthread libdl librt libc"
>> +
>> +RDEPENDS_${PN} = "libnspr4 libplc4 libplds4"
>> +
>> +RDEPENDS_${PN}-plc4 = "libnspr4"
>> +RDEPENDS_${PN}-plds4 = "libnspr4"
>> +
>> +DEPENDS_${PN} = "${LIBS_AUTO_PACKAGES}"
>> diff --git a/recipes/nspr/nspr_4.10.6.oe.sig b/recipes/nspr/nspr_4.10.6.oe.sig
>> new file mode 100644
>> index 0000000..8aacd1c
>> --- /dev/null
>> +++ b/recipes/nspr/nspr_4.10.6.oe.sig
>> @@ -0,0 +1 @@
>> +9f3f278f7f31574b2cdbb99d9703c58e51cd3e1c  nspr-4.10.6.tar.gz
> First of all;
> When upgrading a recipe, please consider splitting the commonalities
> into a .inc file.. Makes it easier to spot the difference between the
> different versions, hereby making it easier to maintain.
> It is quite hard to spot that you added "--enable-64bit" to
> EXTRA_OECONF, and that this was the only change you did, when you just
> copied the entire file instead of splitting it out.
>
> Furthermore, remember to run packageqa on the recipe. It currently fails
> due to missing dependencies..
>
> /Christian
> _______________________________________________
> dev mailing list
> dev@oe-lite.org
> http://lists.oe-lite.org/mailman/listinfo/dev