From patchwork Wed Sep 16 12:07:52 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Engelhardt X-Patchwork-Id: 518375 X-Patchwork-Delegate: pablo@netfilter.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 738A7140157 for ; Wed, 16 Sep 2015 22:08:03 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752175AbbIPMHz (ORCPT ); Wed, 16 Sep 2015 08:07:55 -0400 Received: from ares41.inai.de ([46.4.122.207]:57886 "EHLO ares41.inai.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751917AbbIPMHy (ORCPT ); Wed, 16 Sep 2015 08:07:54 -0400 Received: by ares41.inai.de (Postfix, from userid 25121) id 7F8517CBFB0B; Wed, 16 Sep 2015 14:07:52 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by ares41.inai.de (Postfix) with ESMTP id 6B3DA80433CD; Wed, 16 Sep 2015 14:07:52 +0200 (CEST) Date: Wed, 16 Sep 2015 14:07:52 +0200 (CEST) From: Jan Engelhardt To: Pablo Neira Ayuso cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org, netfilter@vger.kernel.org, netfilter-announce@lists.netfilter.org, lwn@lwn.net Subject: Re: [ANNOUNCE] libnftnl 1.0.4 release In-Reply-To: <20150916115004.GA1102@salvia> Message-ID: References: <20150916115004.GA1102@salvia> User-Agent: Alpine 2.20 (LSU 67 2015-01-07) MIME-Version: 1.0 Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Wednesday 2015-09-16 13:50, Pablo Neira Ayuso wrote: >The Netfilter project proudly presents: > > libnftnl 1.0.4 $ git diff libnftnl-1.0.3..libnftnl-1.0.4 src/libnftnl.map You broke the ABI. A program that uses nft_set_attr_set_u64 and is built against libnftnl-1.0.4 is marked to be compatible with the "LIBNFTNL_1.0" symbol group, but this is incorrect, since the nft_set_attr_set_u64 symbol did not previously exist. Existing symbol groups in .map must not be extended. Always start a new group. --- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/src/libnftnl.map b/src/libnftnl.map index be7b998..14ec88c 100644 --- a/src/libnftnl.map +++ b/src/libnftnl.map @@ -124,10 +123,12 @@ global: nft_set_attr_is_set; nft_set_attr_set; nft_set_attr_set_u32; + nft_set_attr_set_u64; nft_set_attr_set_str; nft_set_attr_get; nft_set_attr_get_str; nft_set_attr_get_u32; + nft_set_attr_get_u64; nft_set_nlmsg_build_payload; nft_set_nlmsg_parse; nft_set_parse;