From patchwork Thu Mar 8 09:45:44 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 145475 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id C07B5B6EEE for ; Thu, 8 Mar 2012 20:45:02 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751527Ab2CHJo7 (ORCPT ); Thu, 8 Mar 2012 04:44:59 -0500 Received: from nat28.tlf.novell.com ([130.57.49.28]:63628 "EHLO nat28.tlf.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752094Ab2CHJo7 convert rfc822-to-8bit (ORCPT ); Thu, 8 Mar 2012 04:44:59 -0500 Received: from EMEA1-MTA by nat28.tlf.novell.com with Novell_GroupWise; Thu, 08 Mar 2012 09:44:58 +0000 Message-Id: <4F588DD8020000780007711C@nat28.tlf.novell.com> X-Mailer: Novell GroupWise Internet Agent 12.0.0 Date: Thu, 08 Mar 2012 09:45:44 +0000 From: "Jan Beulich" To: , Cc: Subject: [PATCH] xt_log.h: don't use xchg() for simple assignment Mime-Version: 1.0 Content-Disposition: inline Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org At least on ia64 the (bogus) use of xchg() here results in the compiler warning about an unused expression result. As only an assignment is intended here, convert it to such. Signed-off-by: Jan Beulich Acked-by: Eric Dumazet --- include/net/netfilter/xt_log.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- 3.3-rc6/include/net/netfilter/xt_log.h +++ 3.3-rc6-netfilter-xt_log-no-xchg/include/net/netfilter/xt_log.h @@ -47,7 +47,7 @@ static void sb_close(struct sbuff *m) if (likely(m != &emergency)) kfree(m); else { - xchg(&emergency_ptr, m); + emergency_ptr = m; local_bh_enable(); } }