From patchwork Sun Nov 5 10:02:01 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vasily Averin X-Patchwork-Id: 834305 X-Patchwork-Delegate: pablo@netfilter.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netfilter-devel-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yVB7X2Pdvz9t34 for ; Sun, 5 Nov 2017 21:02:16 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752950AbdKEKCM (ORCPT ); Sun, 5 Nov 2017 05:02:12 -0500 Received: from mailhub.sw.ru ([195.214.232.25]:46631 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752937AbdKEKCL (ORCPT ); Sun, 5 Nov 2017 05:02:11 -0500 Received: from [172.16.24.21] (msk-vpn.virtuozzo.com [195.214.232.6]) by relay.sw.ru (8.13.4/8.13.4) with ESMTP id vA5A21D5013661; Sun, 5 Nov 2017 13:02:01 +0300 (MSK) From: Vasily Averin Subject: [PATCH 16/21] x_tables: exit_net cleanup check added To: netdev@vger.kernel.org Cc: coreteam@netfilter.org, netfilter-devel@vger.kernel.org, Florian Westphal , Jozsef Kadlecsik , Pablo Neira Ayuso Message-ID: <3cf1e9ee-0432-0062-5c4f-c287a00de3df@virtuozzo.com> Date: Sun, 5 Nov 2017 13:02:01 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 Content-Language: en-US Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Be sure that xt.tables array initialized in net_init hook was return to initial state. Signed-off-by: Vasily Averin --- net/netfilter/x_tables.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/net/netfilter/x_tables.c b/net/netfilter/x_tables.c index d8571f4..7e74b37 100644 --- a/net/netfilter/x_tables.c +++ b/net/netfilter/x_tables.c @@ -1714,8 +1714,18 @@ static int __net_init xt_net_init(struct net *net) return 0; } +static void __net_exit xt_net_exit(struct net *net) +{ + int i; + + for (i = 0; i < NFPROTO_NUMPROTO; i++) + WARN(!list_empty(&net->xt.tables[i]), + "net %p exit: xt tables list is not empty\n", net); +} + static struct pernet_operations xt_net_ops = { .init = xt_net_init, + .exit = xt_net_exit, }; static int __init xt_init(void)