diff mbox series

iptables: cleanup FIXME

Message ID 20240523145058.747280-1-michaelestner@web.de
State Changes Requested
Headers show
Series iptables: cleanup FIXME | expand

Commit Message

Michael Estner May 23, 2024, 2:50 p.m. UTC 
Remove obsolet FIXME since struct ebt_entry has no flags var.
Update the debug output.

Signed-off-by: Michael Estner <michaelestner@web.de>
---
 iptables/nft-bridge.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--
2.25.1

Comments

Phil Sutter May 23, 2024, 4:45 p.m. UTC | #1 
On Thu, May 23, 2024 at 04:50:58PM +0200, Michael Estner wrote:
> Remove obsolet FIXME since struct ebt_entry has no flags var.
> Update the debug output.

It never had, but there's bitmask and I wonder if it should compare
those values instead.

Cheers, Phil
diff mbox series

Patch

diff --git a/iptables/nft-bridge.c b/iptables/nft-bridge.c
index 922ce983..f5deaa93 100644
--- a/iptables/nft-bridge.c
+++ b/iptables/nft-bridge.c
@@ -373,9 +373,8 @@  static bool nft_bridge_is_same(const struct iptables_command_state *cs_a,
 	int i;

 	if (a->ethproto != b->ethproto ||
-	    /* FIXME: a->flags != b->flags || */
 	    a->invflags != b->invflags) {
-		DEBUGP("different proto/flags/invflags\n");
+		DEBUGP("different proto/invflags\n");
 		return false;
 	}