| Message ID | 20240301170731.21657-3-donald.yandt@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | fix potential memory loss and exit codes | expand |
Hi, Could you describe why these are needed? Thanks! On Fri, Mar 01, 2024 at 12:07:30PM -0500, Donald Yandt wrote: > Signed-off-by: Donald Yandt <donald.yandt@gmail.com> > --- > src/vector.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/src/vector.c b/src/vector.c > index 7f9bc3c..ac1f5d9 100644 > --- a/src/vector.c > +++ b/src/vector.c > @@ -23,9 +23,7 @@ > > struct vector { > char *data; > - unsigned int cur_elems; > - unsigned int max_elems; > - size_t size; > + size_t cur_elems, max_elems, size; > }; > > #define DEFAULT_VECTOR_MEMBERS 8 > -- > 2.44.0 > >
On Sat, Mar 2, 2024 at 4:53 AM Pablo Neira Ayuso <pablo@netfilter.org> wrote: > > Hi, > > Could you describe why these are needed? > > Thanks! > Hi Pablo, I mentioned it briefly in the cover letter and explained why it should be used in the commit message for version 2. If you require any additional detail, please let me know. Thank you On Sat, Mar 2, 2024 at 4:53 AM Pablo Neira Ayuso <pablo@netfilter.org> wrote: > > Hi, > > Could you describe why these are needed? > > Thanks! > > On Fri, Mar 01, 2024 at 12:07:30PM -0500, Donald Yandt wrote: > > Signed-off-by: Donald Yandt <donald.yandt@gmail.com> > > --- > > src/vector.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/src/vector.c b/src/vector.c > > index 7f9bc3c..ac1f5d9 100644 > > --- a/src/vector.c > > +++ b/src/vector.c > > @@ -23,9 +23,7 @@ > > > > struct vector { > > char *data; > > - unsigned int cur_elems; > > - unsigned int max_elems; > > - size_t size; > > + size_t cur_elems, max_elems, size; > > }; > > > > #define DEFAULT_VECTOR_MEMBERS 8 > > -- > > 2.44.0 > > > >
On Sat, Mar 02, 2024 at 11:20:38AM -0500, Donald Yandt wrote: > On Sat, Mar 2, 2024 at 4:53 AM Pablo Neira Ayuso <pablo@netfilter.org> wrote: > > > > Hi, > > > > Could you describe why these are needed? > > > > Thanks! > > > > Hi Pablo, > > I mentioned it briefly in the cover letter and explained why it should > be used in the commit message for version 2. > If you require any additional detail, please let me know. Cover letter gets lost when applying patches. Split descriptions into each individual commit, it really helps us. Thanks a lot
diff --git a/src/vector.c b/src/vector.c index 7f9bc3c..ac1f5d9 100644 --- a/src/vector.c +++ b/src/vector.c @@ -23,9 +23,7 @@ struct vector { char *data; - unsigned int cur_elems; - unsigned int max_elems; - size_t size; + size_t cur_elems, max_elems, size; }; #define DEFAULT_VECTOR_MEMBERS 8
Signed-off-by: Donald Yandt <donald.yandt@gmail.com> --- src/vector.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)