diff mbox series

[nft,2/2] netlink_linearize: add assertion to catch for buggy byteorder

Message ID 20240208125447.272965-2-pablo@netfilter.org
State Accepted
Headers show
Series [v2,nft,1/2] evaluate: skip byteorder conversion for selector smaller than 2 bytes | expand

Commit Message

Pablo Neira Ayuso Feb. 8, 2024, 12:54 p.m. UTC 
Add assertion to catch buggy bytecode where unary expression is present
with 1-byte, where no byteorder conversion is required.

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
 src/netlink_linearize.c | 2 ++
 1 file changed, 2 insertions(+)
diff mbox series

Patch

diff --git a/src/netlink_linearize.c b/src/netlink_linearize.c
index 50dbd36c1b8e..6204d8fd2668 100644
--- a/src/netlink_linearize.c
+++ b/src/netlink_linearize.c
@@ -797,6 +797,8 @@  static void netlink_gen_unary(struct netlink_linearize_ctx *ctx,
 	struct nftnl_expr *nle;
 	int byte_size;
 
+	assert(div_round_up(expr->arg->len, BITS_PER_BYTE) != 1);
+
 	if ((expr->arg->len % 64) == 0)
 		byte_size = 8;
 	else if ((expr->arg->len % 32) == 0)