| Message ID | 20231108182230.3999140-1-thaller@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [nft] netlink: fix buffer size for user data in netlink_delinearize_chain() | expand |
On Wed, Nov 08, 2023 at 07:22:20PM +0100, Thomas Haller wrote: > The correct define is NFTNL_UDATA_CHAIN_MAX and not NFTNL_UDATA_OBJ_MAX. > In current libnftnl, they both are defined as 1, so (with current libnftnl) > there is no difference. Good catch, applied, thanks Thomas.
diff --git a/src/netlink.c b/src/netlink.c index 2876ebad5a78..1d18280bb8c1 100644 --- a/src/netlink.c +++ b/src/netlink.c @@ -614,7 +614,7 @@ static int qsort_device_cmp(const void *a, const void *b) struct chain *netlink_delinearize_chain(struct netlink_ctx *ctx, const struct nftnl_chain *nlc) { - const struct nftnl_udata *ud[NFTNL_UDATA_OBJ_MAX + 1] = {}; + const struct nftnl_udata *ud[NFTNL_UDATA_CHAIN_MAX + 1] = {}; int priority, policy, len = 0, i; const char * const *dev_array; struct chain *chain;
The correct define is NFTNL_UDATA_CHAIN_MAX and not NFTNL_UDATA_OBJ_MAX. In current libnftnl, they both are defined as 1, so (with current libnftnl) there is no difference. Fixes: 702ac2b72c0e ('src: add comment support for chains') Signed-off-by: Thomas Haller <thaller@redhat.com> --- src/netlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)