From patchwork Mon Jun 5 16:00:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: tongxiaoge1001@126.com X-Patchwork-Id: 1790557 X-Patchwork-Delegate: pablo@netfilter.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2620:137:e000::1:20; helo=out1.vger.email; envelope-from=netfilter-devel-owner@vger.kernel.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=126.com header.i=@126.com header.a=rsa-sha256 header.s=s110527 header.b=o8E/xA+D; dkim-atps=neutral Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by legolas.ozlabs.org (Postfix) with ESMTP id 4QZdcb6Kphz20Ty for ; Tue, 6 Jun 2023 02:00:47 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232217AbjFEQAn (ORCPT ); Mon, 5 Jun 2023 12:00:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230445AbjFEQAm (ORCPT ); Mon, 5 Jun 2023 12:00:42 -0400 Received: from m126.mail.126.com (m126.mail.126.com [220.181.12.37]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 52AE3B7 for ; Mon, 5 Jun 2023 09:00:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=/PprR OYzbNTq2/Pvl68nLVIUNed0RFA3mGYfSghbkUE=; b=o8E/xA+DpvhqKrVWFvFPx 4KMLUw+vcv0DvZhhFSRbfjuLu+vncgkoKcyOVz1O5bcxDvaGb8v7K3ue5tNVpo7L iBgTPoUJXnQBRCjceIzRQs8X7XPYclQ7hNqANiC4jBiQnOvVdU+mlOBF/vI+ZqmO IEOzTFE7+1yTfsbKo8ZTgw= Received: from localhost.localdomain (unknown [58.101.35.131]) by zwqz-smtp-mta-g3-1 (Coremail) with SMTP id _____wC3CHuUBn5kW74IAw--.10668S4; Tue, 06 Jun 2023 00:00:22 +0800 (CST) From: tongxiaoge1001@126.com To: pablo@netfilter.org Cc: netfilter-devel@vger.kernel.org, shixuantong1@huawei.com, tongxiaoge1001@126.com Subject: [PATCH] define "i" only if attr is NFTNL_CHAIN_DEVICES. When attr isn't NFTNL_CHAIN_DEVICES, "i" is useless. Date: Tue, 6 Jun 2023 00:00:16 +0800 Message-Id: <20230605160016.105485-1-tongxiaoge1001@126.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: References: MIME-Version: 1.0 X-CM-TRANSID: _____wC3CHuUBn5kW74IAw--.10668S4 X-Coremail-Antispam: 1Uf129KBjvdXoWrZw17ArW5KFyDGF1UKw45Jrb_yoW3Wwb_KF 1jqFWkWFW8AF4DJ395tr92kr9aqws5Gr4xG34IyF47t3yYqws7Z3WktFZ3Wrn5JayvyF92 ya43ArnYkrW3AjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUncAw7UUUUU== X-Originating-IP: [58.101.35.131] X-CM-SenderInfo: pwrqw55ldrwvirqqiqqrswhudrp/1tbiihSFWlpEDx6d+QAAsq X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org From: shixuantong --- src/chain.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/chain.c b/src/chain.c index dcfcd04..eb2cba7 100644 --- a/src/chain.c +++ b/src/chain.c @@ -150,8 +150,6 @@ bool nftnl_chain_is_set(const struct nftnl_chain *c, uint16_t attr) EXPORT_SYMBOL(nftnl_chain_unset); void nftnl_chain_unset(struct nftnl_chain *c, uint16_t attr) { - int i; - if (!(c->flags & (1 << attr))) return; @@ -181,7 +179,7 @@ void nftnl_chain_unset(struct nftnl_chain *c, uint16_t attr) xfree(c->dev); break; case NFTNL_CHAIN_DEVICES: - for (i = 0; i < c->dev_array_len; i++) + for (int i = 0; i < c->dev_array_len; i++) xfree(c->dev_array[i]); xfree(c->dev_array); break;