| Message ID | 20220623175000.49259-4-mikhail.sennikovskii@ionos.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Pablo Neira |
| Headers | show |
| Series | conntrack: fixes for handling unknown protocols | expand |
On Thu, Jun 23, 2022 at 07:49:57PM +0200, Mikhail Sennikovsky wrote: > Testcases covering passing invalid protocol values via -p parameter. > * -p 256 should fail > * -p foo should fail > which does not work properly at the moment. > Fix included in the next commit. Please, collapse this to next patch 4/6 in v2. > Signed-off-by: Mikhail Sennikovsky <mikhail.sennikovskii@ionos.com> > --- > tests/conntrack/testsuite/00create | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/tests/conntrack/testsuite/00create b/tests/conntrack/testsuite/00create > index 9962e23..9fb3a0b 100644 > --- a/tests/conntrack/testsuite/00create > +++ b/tests/conntrack/testsuite/00create > @@ -61,3 +61,8 @@ > -D -s 0.0.0.0 -d 224.0.0.22 -r 224.0.0.22 -q 0.0.0.0 -p 200 ; OK > # delete again > -D -s 0.0.0.0 -d 224.0.0.22 -r 224.0.0.22 -q 0.0.0.0 -p 200 ; BAD > +# Invalid protocol values > +# 256 should fail > +-I -t 10 -s 1.1.1.1 -d 2.2.2.2 -r 2.2.2.2 -q 1.1.1.1 -p 256 ; BAD > +# take some invalid protocol name > +-I -t 10 -s 0.0.0.0 -d 224.0.0.22 -r 224.0.0.22 -q 0.0.0.0 -p foo ; BAD > -- > 2.25.1 >
diff --git a/tests/conntrack/testsuite/00create b/tests/conntrack/testsuite/00create index 9962e23..9fb3a0b 100644 --- a/tests/conntrack/testsuite/00create +++ b/tests/conntrack/testsuite/00create @@ -61,3 +61,8 @@ -D -s 0.0.0.0 -d 224.0.0.22 -r 224.0.0.22 -q 0.0.0.0 -p 200 ; OK # delete again -D -s 0.0.0.0 -d 224.0.0.22 -r 224.0.0.22 -q 0.0.0.0 -p 200 ; BAD +# Invalid protocol values +# 256 should fail +-I -t 10 -s 1.1.1.1 -d 2.2.2.2 -r 2.2.2.2 -q 1.1.1.1 -p 256 ; BAD +# take some invalid protocol name +-I -t 10 -s 0.0.0.0 -d 224.0.0.22 -r 224.0.0.22 -q 0.0.0.0 -p foo ; BAD
Testcases covering passing invalid protocol values via -p parameter. * -p 256 should fail * -p foo should fail which does not work properly at the moment. Fix included in the next commit. Signed-off-by: Mikhail Sennikovsky <mikhail.sennikovskii@ionos.com> --- tests/conntrack/testsuite/00create | 5 +++++ 1 file changed, 5 insertions(+)