diff mbox series

[iptables,2/2] libxtables: Define XT_OPTION_OFFSET_SCALE in xtables.h

Message ID 20220611100742.4888-3-phil@nwl.cc
State Accepted
Delegated to: Pablo Neira
Headers show
Series Review xtables.h vs. xshared.h | expand

Commit Message

Phil Sutter June 11, 2022, 10:07 a.m. UTC 
This is the last symbol in xshared.h used by libxtables, move it over.
Again, treat this as "implementation detail" and hence put it behind
XTABLES_INTERNAL-curtains.

Signed-off-by: Phil Sutter <phil@nwl.cc>
---
 include/xtables.h      | 3 +++
 iptables/xshared.h     | 4 ----
 libxtables/xtables.c   | 1 -
 libxtables/xtoptions.c | 1 -
 4 files changed, 3 insertions(+), 6 deletions(-)
diff mbox series

Patch

diff --git a/include/xtables.h b/include/xtables.h
index b8d8372d0e498..9eba4f619d351 100644
--- a/include/xtables.h
+++ b/include/xtables.h
@@ -687,6 +687,9 @@  struct xtables_afinfo {
 
 extern const struct xtables_afinfo *afinfo;
 
+/* base offset of merged extensions' consecutive options */
+#define XT_OPTION_OFFSET_SCALE	256
+
 #endif /* XTABLES_INTERNAL */
 
 #ifdef __cplusplus
diff --git a/iptables/xshared.h b/iptables/xshared.h
index 1fdc760a32442..1a019a7c04882 100644
--- a/iptables/xshared.h
+++ b/iptables/xshared.h
@@ -132,10 +132,6 @@  struct subcommand {
 	mainfunc_t main;
 };
 
-enum {
-	XT_OPTION_OFFSET_SCALE = 256,
-};
-
 extern int subcmd_main(int, char **, const struct subcommand *);
 extern void xs_init_target(struct xtables_target *);
 extern void xs_init_match(struct xtables_match *);
diff --git a/libxtables/xtables.c b/libxtables/xtables.c
index 0638f9271c601..dc645162973f0 100644
--- a/libxtables/xtables.c
+++ b/libxtables/xtables.c
@@ -64,7 +64,6 @@ 
 #endif
 #include <getopt.h>
 #include "iptables/internal.h"
-#include "xshared.h"
 
 #define NPROTO	255
 
diff --git a/libxtables/xtoptions.c b/libxtables/xtoptions.c
index 9d3ac5c8066cb..8174a560ec4df 100644
--- a/libxtables/xtoptions.c
+++ b/libxtables/xtoptions.c
@@ -21,7 +21,6 @@ 
 #include <arpa/inet.h>
 #include <netinet/ip.h>
 #include "xtables.h"
-#include "xshared.h"
 #ifndef IPTOS_NORMALSVC
 #	define IPTOS_NORMALSVC 0
 #endif