Message ID | 20211215184440.39507-1-jeremy@azazel.net |
---|---|
State | Accepted |
Delegated to: | Pablo Neira |
Headers | show |
Series | build: fix autoconf warnings | expand |
On 2021-12-15, at 18:44:40 +0000, Jeremy Sowden wrote: > autoconf complains about three obsolete macros. > > `AC_CONFIG_HEADER` has been superseded by `AC_CONFIG_HEADERS`, so > replace it. > > `AM_PROG_LEX` calls `AC_PROG_LEX` with no arguments, but this usage is > deprecated. The only difference between `AM_PROG_LEX` and `AC_PROG_LEX` > is that the former defines `$LEX` as "./build-aux/missing lex" if no lex > is found to ensure a useful error is reported when make is run. How- > ever, the configure script checks that we have a working lex and exits > with an error if none is available, so `$LEX` will never be called and > we can replace `AM_PROG_LEX` with `AC_PROG_LEX`. > > `AM_PROG_LIBTOOL` has been superseded by `LT_INIT`, which is already in > configure.ac, so remove it. > > We can also replace `AC_DISABLE_STATIC` with an argument to `LT_INIT`. > > Signed-off-by: Jeremy Sowden <jeremy@azazel.net> > --- > configure.ac | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/configure.ac b/configure.ac > index bb65f749691c..503883f28c66 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -9,7 +9,7 @@ AM_INIT_AUTOMAKE([-Wall foreign subdir-objects > dnl kernel style compile messages > m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])]) > > -AC_CONFIG_HEADER([config.h]) > +AC_CONFIG_HEADERS([config.h]) > > AC_ARG_ENABLE([debug], > AS_HELP_STRING([--disable-debug], [Disable debugging symbols]), > @@ -26,7 +26,7 @@ AC_PROG_CC > AC_PROG_MKDIR_P > AC_PROG_INSTALL > AC_PROG_SED > -AM_PROG_LEX > +AC_PROG_LEX([noyywrap]) > AC_PROG_YACC > > if test -z "$ac_cv_prog_YACC" -a ! -f "${srcdir}/src/parser_bison.c" > @@ -43,11 +43,9 @@ then > fi > > AM_PROG_AR > -AM_PROG_LIBTOOL > -LT_INIT > +LT_INIT([disable-static]) > AM_PROG_CC_C_O > AC_EXEEXT > -AC_DISABLE_STATIC > CHECK_GCC_FVISIBILITY > > AS_IF([test "x$enable_man_doc" = "xyes"], [ > -- > 2.34.1 > > Forgot to set the subject-prefix to "nft". Apologies, J.
On Wed, Dec 15, 2021 at 06:44:40PM +0000, Jeremy Sowden wrote: > autoconf complains about three obsolete macros. > > `AC_CONFIG_HEADER` has been superseded by `AC_CONFIG_HEADERS`, so > replace it. > > `AM_PROG_LEX` calls `AC_PROG_LEX` with no arguments, but this usage is > deprecated. The only difference between `AM_PROG_LEX` and `AC_PROG_LEX` > is that the former defines `$LEX` as "./build-aux/missing lex" if no lex > is found to ensure a useful error is reported when make is run. How- > ever, the configure script checks that we have a working lex and exits > with an error if none is available, so `$LEX` will never be called and > we can replace `AM_PROG_LEX` with `AC_PROG_LEX`. > > `AM_PROG_LIBTOOL` has been superseded by `LT_INIT`, which is already in > configure.ac, so remove it. > > We can also replace `AC_DISABLE_STATIC` with an argument to `LT_INIT`. Also applied, thanks.
diff --git a/configure.ac b/configure.ac index bb65f749691c..503883f28c66 100644 --- a/configure.ac +++ b/configure.ac @@ -9,7 +9,7 @@ AM_INIT_AUTOMAKE([-Wall foreign subdir-objects dnl kernel style compile messages m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])]) -AC_CONFIG_HEADER([config.h]) +AC_CONFIG_HEADERS([config.h]) AC_ARG_ENABLE([debug], AS_HELP_STRING([--disable-debug], [Disable debugging symbols]), @@ -26,7 +26,7 @@ AC_PROG_CC AC_PROG_MKDIR_P AC_PROG_INSTALL AC_PROG_SED -AM_PROG_LEX +AC_PROG_LEX([noyywrap]) AC_PROG_YACC if test -z "$ac_cv_prog_YACC" -a ! -f "${srcdir}/src/parser_bison.c" @@ -43,11 +43,9 @@ then fi AM_PROG_AR -AM_PROG_LIBTOOL -LT_INIT +LT_INIT([disable-static]) AM_PROG_CC_C_O AC_EXEEXT -AC_DISABLE_STATIC CHECK_GCC_FVISIBILITY AS_IF([test "x$enable_man_doc" = "xyes"], [
autoconf complains about three obsolete macros. `AC_CONFIG_HEADER` has been superseded by `AC_CONFIG_HEADERS`, so replace it. `AM_PROG_LEX` calls `AC_PROG_LEX` with no arguments, but this usage is deprecated. The only difference between `AM_PROG_LEX` and `AC_PROG_LEX` is that the former defines `$LEX` as "./build-aux/missing lex" if no lex is found to ensure a useful error is reported when make is run. How- ever, the configure script checks that we have a working lex and exits with an error if none is available, so `$LEX` will never be called and we can replace `AM_PROG_LEX` with `AC_PROG_LEX`. `AM_PROG_LIBTOOL` has been superseded by `LT_INIT`, which is already in configure.ac, so remove it. We can also replace `AC_DISABLE_STATIC` with an argument to `LT_INIT`. Signed-off-by: Jeremy Sowden <jeremy@azazel.net> --- configure.ac | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)