diff mbox series

[iptables] xlate-test: Print full path if testing all files

Message ID 20211106205201.14284-1-phil@nwl.cc
State Accepted
Delegated to: Pablo Neira
Headers show
Series [iptables] xlate-test: Print full path if testing all files | expand

Commit Message

Phil Sutter Nov. 6, 2021, 8:52 p.m. UTC 
Lines won't become too long and it's more clear to users where test
input comes from this way.

Signed-off-by: Phil Sutter <phil@nwl.cc>
---
 xlate-test.py | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

Comments

Pablo Neira Ayuso Nov. 8, 2021, 11:05 a.m. UTC | #1 
On Sat, Nov 06, 2021 at 09:52:01PM +0100, Phil Sutter wrote:
> Lines won't become too long and it's more clear to users where test
> input comes from this way.
> 
> Signed-off-by: Phil Sutter <phil@nwl.cc>

Tested-by: Pablo Neira Ayuso <pablo@netfilter.org>
diff mbox series

Patch

diff --git a/xlate-test.py b/xlate-test.py
index 4a56e798b9587..d78e864869318 100755
--- a/xlate-test.py
+++ b/xlate-test.py
@@ -80,15 +80,15 @@  def run_test(name, payload):
 
 def load_test_files():
     test_files = total_tests = total_passed = total_error = total_failed = 0
-    for test in sorted(os.listdir("extensions")):
-        if test.endswith(".txlate"):
-            with open("extensions/" + test, "r") as payload:
-                tests, passed, failed, errors = run_test(test, payload)
-                test_files += 1
-                total_tests += tests
-                total_passed += passed
-                total_failed += failed
-                total_error += errors
+    tests = sorted(os.listdir("extensions"))
+    for test in ['extensions/' + f for f in tests if f.endswith(".txlate")]:
+        with open(test, "r") as payload:
+            tests, passed, failed, errors = run_test(test, payload)
+            test_files += 1
+            total_tests += tests
+            total_passed += passed
+            total_failed += failed
+            total_error += errors
     return (test_files, total_tests, total_passed, total_failed, total_error)