Message ID | 20211106164953.130024-11-jeremy@azazel.net |
---|---|
State | Changes Requested |
Delegated to: | Pablo Neira |
Headers | show
Return-Path: <netfilter-devel-owner@vger.kernel.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=azazel.net header.i=@azazel.net header.a=rsa-sha256 header.s=20190108 header.b=ZfIK6xKD; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netfilter-devel-owner@vger.kernel.org; receiver=<UNKNOWN>) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by bilbo.ozlabs.org (Postfix) with ESMTP id 4HmkWn6lVLz9ssD for <incoming@patchwork.ozlabs.org>; Sun, 7 Nov 2021 04:14:45 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234649AbhKFRRY (ORCPT <rfc822;incoming@patchwork.ozlabs.org>); Sat, 6 Nov 2021 13:17:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232948AbhKFRRY (ORCPT <rfc822;netfilter-devel@vger.kernel.org>); Sat, 6 Nov 2021 13:17:24 -0400 Received: from kadath.azazel.net (kadath.azazel.net [IPv6:2001:8b0:135f:bcd1:e0cb:4eff:fedf:e608]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C5F3C061570 for <netfilter-devel@vger.kernel.org>; Sat, 6 Nov 2021 10:14:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=azazel.net; s=20190108; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=MqDvVoiZI8PVBB61Ko9vmd2jEB2twzPs5hpOz3mB/ys=; b=ZfIK6xKDIj7B1AguzmMIXvc0BO fzUYcTyuIl0DOK5zN70fks7uLGR/Qzhlv5n++JGWaeuf6zjUUKx5Rq6j5oXkIzVnP6vA3N1DnhrWy l0df+nM0DcDlYHQ6HNB7mjDP9rkNcoBdXBUBY0Fp+FarQsf+0GhkhJu2fKDDFyA5e9yQtfaqDXNQ6 T0SHVjqrIlRD9wil3yWxk+1pLT6PwNcrJ29KboL5LyYhUsx6fZVPNNQ19n+dt3zHdpdIsQuJKmmvU rK8ThsohxcFIXQ0xwu1dF4GSh3Ntw5+j+2JHudcyLU3eDETqiNMdjf+bnBNt+L+zETezi3Zqez7ZU R47cjhfw==; Received: from ulthar.dreamlands.azazel.net ([2001:8b0:fb7d:d6d7:2e4d:54ff:fe4b:a9ae]) by kadath.azazel.net with esmtp (Exim 4.94.2) (envelope-from <jeremy@azazel.net>) id 1mjOtJ-004m1E-SS for netfilter-devel@vger.kernel.org; Sat, 06 Nov 2021 16:50:05 +0000 From: Jeremy Sowden <jeremy@azazel.net> To: Netfilter Devel <netfilter-devel@vger.kernel.org> Subject: [ulogd2 PATCH v2 10/27] filter: HWHDR: remove zero-initialization of MAC type Date: Sat, 6 Nov 2021 16:49:36 +0000 Message-Id: <20211106164953.130024-11-jeremy@azazel.net> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211106164953.130024-1-jeremy@azazel.net> References: <20211106164953.130024-1-jeremy@azazel.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:8b0:fb7d:d6d7:2e4d:54ff:fe4b:a9ae X-SA-Exim-Mail-From: jeremy@azazel.net X-SA-Exim-Scanned: No (on kadath.azazel.net); SAEximRunCond expanded to false Precedence: bulk List-ID: <netfilter-devel.vger.kernel.org> X-Mailing-List: netfilter-devel@vger.kernel.org |
Series |
Compiler Warning Fixes
|
expand
|
diff --git a/filter/ulogd_filter_HWHDR.c b/filter/ulogd_filter_HWHDR.c index 015121511b08..bbca5e9b92f2 100644 --- a/filter/ulogd_filter_HWHDR.c +++ b/filter/ulogd_filter_HWHDR.c @@ -171,7 +171,7 @@ static int interp_mac2str(struct ulogd_pluginstance *pi) { struct ulogd_key *ret = pi->output.keys; struct ulogd_key *inp = pi->input.keys; - uint16_t type = 0; + uint16_t type; if (pp_is_valid(inp, KEY_OOB_PROTOCOL)) okey_set_u16(&ret[KEY_MAC_PROTOCOL],
We don't need to initialize `type`, and even if we did the right value would be `ARPHDR_VOID`, not `0` which is a valid MAC type (`ARPHDR_NETROM`). Signed-off-by: Jeremy Sowden <jeremy@azazel.net> --- filter/ulogd_filter_HWHDR.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)