From patchwork Wed Mar 31 14:15:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pablo Neira Ayuso X-Patchwork-Id: 1460555 X-Patchwork-Delegate: pablo@netfilter.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netfilter-devel-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4F9Szw5yb1z9sVq for ; Thu, 1 Apr 2021 01:16:44 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235842AbhCaOQJ (ORCPT ); Wed, 31 Mar 2021 10:16:09 -0400 Received: from mail.netfilter.org ([217.70.188.207]:48042 "EHLO mail.netfilter.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235865AbhCaOPh (ORCPT ); Wed, 31 Mar 2021 10:15:37 -0400 Received: from localhost.localdomain (unknown [90.77.255.23]) by mail.netfilter.org (Postfix) with ESMTPSA id 289BC630C2 for ; Wed, 31 Mar 2021 16:15:22 +0200 (CEST) From: Pablo Neira Ayuso To: netfilter-devel@vger.kernel.org Subject: [PATCH nft 1/2] mnl: do not set flowtable flags twice Date: Wed, 31 Mar 2021 16:15:32 +0200 Message-Id: <20210331141533.25158-1-pablo@netfilter.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Flags are already set on from mnl_nft_flowtable_add(), remove duplicated code. Fixes: e6cc9f37385 ("nftables: add flags offload to flowtable") Signed-off-by: Pablo Neira Ayuso --- src/mnl.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/mnl.c b/src/mnl.c index ffbfe48158de..deea586f9b00 100644 --- a/src/mnl.c +++ b/src/mnl.c @@ -1779,11 +1779,6 @@ int mnl_nft_flowtable_add(struct netlink_ctx *ctx, struct cmd *cmd, nftnl_flowtable_set_u32(flo, NFTNL_FLOWTABLE_PRIO, 0); } - if (cmd->flowtable->flags & FLOWTABLE_F_HW_OFFLOAD) { - nftnl_flowtable_set_u32(flo, NFTNL_FLOWTABLE_FLAGS, - NFT_FLOWTABLE_HW_OFFLOAD); - } - if (cmd->flowtable->dev_expr) { dev_array = nft_flowtable_dev_array(cmd); nftnl_flowtable_set_data(flo, NFTNL_FLOWTABLE_DEVICES,