| Message ID | 20210330064232.11960-1-fw@strlen.de |
|---|---|
| State | Accepted |
| Delegated to: | Pablo Neira |
| Headers | show |
| Series | [nf-next] netfilter: ipvs: do not printk on netns creation | expand |
Hello, On Tue, 30 Mar 2021, Florian Westphal wrote: > This causes dmesg spew during normal operation, so remove this. > > Signed-off-by: Florian Westphal <fw@strlen.de> Looks good to me, thanks! Acked-by: Julian Anastasov <ja@ssi.bg> > --- > net/netfilter/ipvs/ip_vs_ftp.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/net/netfilter/ipvs/ip_vs_ftp.c b/net/netfilter/ipvs/ip_vs_ftp.c > index cf925906f59b..ef1f45e43b63 100644 > --- a/net/netfilter/ipvs/ip_vs_ftp.c > +++ b/net/netfilter/ipvs/ip_vs_ftp.c > @@ -591,8 +591,6 @@ static int __net_init __ip_vs_ftp_init(struct net *net) > ret = register_ip_vs_app_inc(ipvs, app, app->protocol, ports[i]); > if (ret) > goto err_unreg; > - pr_info("%s: loaded support on port[%d] = %u\n", > - app->name, i, ports[i]); > } > return 0; > > -- > 2.26.3 Regards -- Julian Anastasov <ja@ssi.bg>
On Fri, Apr 02, 2021 at 06:07:23AM +0300, Julian Anastasov wrote: > > Hello, > > On Tue, 30 Mar 2021, Florian Westphal wrote: > > > This causes dmesg spew during normal operation, so remove this. > > > > Signed-off-by: Florian Westphal <fw@strlen.de> > > Looks good to me, thanks! > > Acked-by: Julian Anastasov <ja@ssi.bg> Reviewed-by: Simon Horman <horms@verge.net.au> > > > --- > > net/netfilter/ipvs/ip_vs_ftp.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/net/netfilter/ipvs/ip_vs_ftp.c b/net/netfilter/ipvs/ip_vs_ftp.c > > index cf925906f59b..ef1f45e43b63 100644 > > --- a/net/netfilter/ipvs/ip_vs_ftp.c > > +++ b/net/netfilter/ipvs/ip_vs_ftp.c > > @@ -591,8 +591,6 @@ static int __net_init __ip_vs_ftp_init(struct net *net) > > ret = register_ip_vs_app_inc(ipvs, app, app->protocol, ports[i]); > > if (ret) > > goto err_unreg; > > - pr_info("%s: loaded support on port[%d] = %u\n", > > - app->name, i, ports[i]); > > } > > return 0; > > > > -- > > 2.26.3 > > Regards > > -- > Julian Anastasov <ja@ssi.bg> >
On Tue, Mar 30, 2021 at 08:42:32AM +0200, Florian Westphal wrote:
> This causes dmesg spew during normal operation, so remove this.
Applied, thanks
diff --git a/net/netfilter/ipvs/ip_vs_ftp.c b/net/netfilter/ipvs/ip_vs_ftp.c index cf925906f59b..ef1f45e43b63 100644 --- a/net/netfilter/ipvs/ip_vs_ftp.c +++ b/net/netfilter/ipvs/ip_vs_ftp.c @@ -591,8 +591,6 @@ static int __net_init __ip_vs_ftp_init(struct net *net) ret = register_ip_vs_app_inc(ipvs, app, app->protocol, ports[i]); if (ret) goto err_unreg; - pr_info("%s: loaded support on port[%d] = %u\n", - app->name, i, ports[i]); } return 0;
This causes dmesg spew during normal operation, so remove this. Signed-off-by: Florian Westphal <fw@strlen.de> --- net/netfilter/ipvs/ip_vs_ftp.c | 2 -- 1 file changed, 2 deletions(-)