diff mbox series

[nft,1/2] main: fix nft --help output fallout from 719e4427

Message ID 20210222120320.2252514-1-snemec@redhat.com
State Accepted
Delegated to: Pablo Neira
Headers show
Series [nft,1/2] main: fix nft --help output fallout from 719e4427 | expand

Commit Message

Štěpán Němec Feb. 22, 2021, 12:03 p.m. UTC 
Long options were missing the double dash.

Fixes: 719e44277f8e ("main: use one data-structure to initialize getopt_long(3) arguments and help.")
Cc: Jeremy Sowden <jeremy@azazel.net>
Signed-off-by: Štěpán Němec <snemec@redhat.com>
---
 src/main.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Comments

Pablo Neira Ayuso Feb. 22, 2021, 1:52 p.m. UTC | #1 
On Mon, Feb 22, 2021 at 01:03:19PM +0100, Štěpán Němec wrote:
> Long options were missing the double dash.

Applied, thanks
diff mbox series

Patch

diff --git a/src/main.c b/src/main.c
index 80cf1acf0f7f..8c47064459ec 100644
--- a/src/main.c
+++ b/src/main.c
@@ -175,16 +175,17 @@  static const struct option *get_options(void)
 
 static void print_option(const struct nft_opt *opt)
 {
-	char optbuf[33] = "";
+	char optbuf[35] = "";
 	int i;
 
 	i = snprintf(optbuf, sizeof(optbuf), "  -%c", opt->val);
 	if (opt->name)
-		i += snprintf(optbuf + i, sizeof(optbuf) - i, ", %s", opt->name);
+		i += snprintf(optbuf + i, sizeof(optbuf) - i, ", --%s",
+			      opt->name);
 	if (opt->arg)
 		i += snprintf(optbuf + i, sizeof(optbuf) - i, " %s", opt->arg);
 
-	printf("%-32s%s\n", optbuf, opt->help);
+	printf("%-34s%s\n", optbuf, opt->help);
 }
 
 static void show_help(const char *name)