diff mbox series

tests: dump generated use new nft tool

Message ID 20200501210949.2712-1-michael-dev@fami-braun.de
State Accepted
Delegated to: Pablo Neira
Headers show
Series tests: dump generated use new nft tool | expand

Commit Message

michael-dev May 1, 2020, 9:09 p.m. UTC
Instead of using an (possibly outdated) system nft to generate dumps,
use the newly build tool.

This fixes the dump output being corrupted if the system tool does
not support parsing new features.

Signed-off-by: Michael Braun <michael-dev@fami-braun.de>
---
 tests/shell/run-tests.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Pablo Neira Ayuso May 1, 2020, 9:56 p.m. UTC | #1
On Fri, May 01, 2020 at 11:09:49PM +0200, Michael Braun wrote:
> Instead of using an (possibly outdated) system nft to generate dumps,
> use the newly build tool.
> 
> This fixes the dump output being corrupted if the system tool does
> not support parsing new features.

Applied, thanks.
diff mbox series

Patch

diff --git a/tests/shell/run-tests.sh b/tests/shell/run-tests.sh
index 2c415489..26f8f46d 100755
--- a/tests/shell/run-tests.sh
+++ b/tests/shell/run-tests.sh
@@ -122,7 +122,7 @@  do
 
 			if [ "$DUMPGEN" == "y" ] && [ "$rc_got" == 0 ] && [ ! -f "${dumpfile}" ]; then
 				mkdir -p "${dumppath}"
-				nft list ruleset > "${dumpfile}"
+				$NFT list ruleset > "${dumpfile}"
 			fi
 		else
 			((failed++))