From patchwork Thu Nov 7 08:17:10 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan-Martin Raemer X-Patchwork-Id: 1190973 X-Patchwork-Delegate: pablo@netfilter.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netfilter-devel-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=zit-rlp.de Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 477xHF74N5z9sNx for ; Thu, 7 Nov 2019 19:23:05 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727354AbfKGIXF (ORCPT ); Thu, 7 Nov 2019 03:23:05 -0500 Received: from smtpout.hs-koblenz.de ([143.93.243.5]:58742 "EHLO smtpout.hs-koblenz.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726734AbfKGIXE (ORCPT ); Thu, 7 Nov 2019 03:23:04 -0500 X-Greylist: delayed 350 seconds by postgrey-1.27 at vger.kernel.org; Thu, 07 Nov 2019 03:23:02 EST Received: from laptop-jmr.hs-koblenz.de (5-57-196-50.ktk-ip.de [5.57.196.50]) by smtpout.hs-koblenz.de (Postfix) with ESMTPSA id E349CC01B1 for ; Thu, 7 Nov 2019 09:17:11 +0100 (CET) Date: Thu, 7 Nov 2019 09:17:10 +0100 From: Jan-Martin Raemer To: netfilter-devel@vger.kernel.org Subject: [PATCH] conntrackd UDP IPv6 destination address not usable (Bug 1378) Message-ID: <20191107081710.GC5020@laptop-jmr.hs-koblenz.de> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.8.0 (2017-02-23) Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Hi, as reported in https://bugzilla.netfilter.org/show_bug.cgi?id=1378, conntrackd refuses to start with a vaild IPv6_Destination_Address, reporting "inet_pton(): IPv6 unsupported" due to a forgotten handling of err>0 (i.e. success). This patch fixes the issue: Signed-off-by: Jan-Martin Raemer Best regards, Jan-Martin diff --git a/src/read_config_yy.y b/src/read_config_yy.y index a4aa7f5..31109c4 100644 --- a/src/read_config_yy.y +++ b/src/read_config_yy.y @@ -467,7 +467,7 @@ udp_option : T_IPV6_DEST_ADDR T_IP dlog(LOG_WARNING, "%s is not a valid IPv6 address", $2); free($2); break; - } else { + } else if (err < 0) { dlog(LOG_ERR, "inet_pton(): IPv6 unsupported!"); exit(EXIT_FAILURE); }