| Message ID | 20180505124426.32526-1-phil@nwl.cc |
|---|---|
| State | Accepted |
| Delegated to: | Pablo Neira |
| Headers | show |
| Series | [nft] proto: Fix wrong token in proto_icmp6 | expand |
On Sat, May 05, 2018 at 02:44:26PM +0200, Phil Sutter wrote: > 'token' value of ICMP6HDR_MTU field must be 'mtu', not 'packet-too-big'. > This went unnoticed because rule delinearization for icmp/icmpv6 payload > expressions is problematic anyway in that different fields point to the > same offset and therefore are indistinguishable. In this case, an > expression like e.g. 'icmpv6 mtu 1500' will be printed later as 'icmpv6 > parameter-problem 1500'. Applied, thanks phil. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/src/proto.c b/src/proto.c index 8cf29d2014dce..ed011efab2229 100644 --- a/src/proto.c +++ b/src/proto.c @@ -689,7 +689,7 @@ const struct proto_desc proto_icmp6 = { [ICMP6HDR_CODE] = ICMP6HDR_FIELD("code", icmp6_code), [ICMP6HDR_CHECKSUM] = ICMP6HDR_FIELD("checksum", icmp6_cksum), [ICMP6HDR_PPTR] = ICMP6HDR_FIELD("parameter-problem", icmp6_pptr), - [ICMP6HDR_MTU] = ICMP6HDR_FIELD("packet-too-big", icmp6_mtu), + [ICMP6HDR_MTU] = ICMP6HDR_FIELD("mtu", icmp6_mtu), [ICMP6HDR_ID] = ICMP6HDR_FIELD("id", icmp6_id), [ICMP6HDR_SEQ] = ICMP6HDR_FIELD("sequence", icmp6_seq), [ICMP6HDR_MAXDELAY] = ICMP6HDR_FIELD("max-delay", icmp6_maxdelay),
'token' value of ICMP6HDR_MTU field must be 'mtu', not 'packet-too-big'. This went unnoticed because rule delinearization for icmp/icmpv6 payload expressions is problematic anyway in that different fields point to the same offset and therefore are indistinguishable. In this case, an expression like e.g. 'icmpv6 mtu 1500' will be printed later as 'icmpv6 parameter-problem 1500'. Signed-off-by: Phil Sutter <phil@nwl.cc> --- src/proto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)