diff mbox series

[nft,2/4] netlink: netlink_list_chains() callers always wants all existing chains

Message ID 20180423230513.21127-2-pablo@netfilter.org
State Accepted
Delegated to: Pablo Neira
Headers show
Series [nft,1/4] netlink: pass cmd object to netlink function calls | expand

Commit Message

Pablo Neira Ayuso April 23, 2018, 11:05 p.m. UTC 
Remove dead code, callers always need this to dump all of the existing
chains.

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
 src/netlink.c | 16 +---------------
 1 file changed, 1 insertion(+), 15 deletions(-)
diff mbox series

Patch

diff --git a/src/netlink.c b/src/netlink.c
index d668fa8cdea3..8e34553635d0 100644
--- a/src/netlink.c
+++ b/src/netlink.c
@@ -711,7 +711,6 @@  int netlink_list_chains(struct netlink_ctx *ctx, const struct handle *h,
 			const struct location *loc)
 {
 	struct nftnl_chain_list *chain_cache;
-	struct chain *chain;
 
 	chain_cache = mnl_nft_chain_dump(ctx, h->family);
 	if (chain_cache == NULL) {
@@ -725,20 +724,7 @@  int netlink_list_chains(struct netlink_ctx *ctx, const struct handle *h,
 	nftnl_chain_list_foreach(chain_cache, list_chain_cb, ctx);
 	nftnl_chain_list_free(chain_cache);
 
-	/* Caller wants all existing chains */
-	if (h->chain == NULL)
-		return 0;
-
-	/* Check if this chain exists, otherwise return an error */
-	list_for_each_entry(chain, &ctx->list, list) {
-		if (strcmp(chain->handle.chain, h->chain) == 0)
-			return 0;
-	}
-
-	return netlink_io_error(ctx, NULL,
-				"Could not find chain `%s' in table `%s': %s",
-				h->chain, h->table,
-				strerror(ENOENT));
+	return 0;
 }
 
 int netlink_flush_chain(struct netlink_ctx *ctx, const struct cmd *cmd)