| Message ID | 20180423210445.18336-1-xiyou.wangcong@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | Pablo Neira |
| Headers | show |
| Series | [nf] ipvs: initialize tbl->entries in ip_vs_lblc_init_svc() | expand |
Hello, On Mon, 23 Apr 2018, Cong Wang wrote: > Similarly, tbl->entries is not initialized after kmalloc(), > therefore causes an uninit-value warning in ip_vs_lblc_check_expire(), > as reported by syzbot. > > Reported-by: <syzbot+3e9695f147fb529aa9bc@syzkaller.appspotmail.com> > Cc: Simon Horman <horms@verge.net.au> > Cc: Julian Anastasov <ja@ssi.bg> > Cc: Pablo Neira Ayuso <pablo@netfilter.org> > Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com> Thanks! Acked-by: Julian Anastasov <ja@ssi.bg> > --- > net/netfilter/ipvs/ip_vs_lblc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/netfilter/ipvs/ip_vs_lblc.c b/net/netfilter/ipvs/ip_vs_lblc.c > index 3057e453bf31..83918119ceb8 100644 > --- a/net/netfilter/ipvs/ip_vs_lblc.c > +++ b/net/netfilter/ipvs/ip_vs_lblc.c > @@ -371,6 +371,7 @@ static int ip_vs_lblc_init_svc(struct ip_vs_service *svc) > tbl->counter = 1; > tbl->dead = false; > tbl->svc = svc; > + atomic_set(&tbl->entries, 0); > > /* > * Hook periodic timer for garbage collection > -- > 2.13.0 Regards -- Julian Anastasov <ja@ssi.bg> -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Apr 24, 2018 at 08:17:06AM +0300, Julian Anastasov wrote: > > Hello, > > On Mon, 23 Apr 2018, Cong Wang wrote: > > > Similarly, tbl->entries is not initialized after kmalloc(), > > therefore causes an uninit-value warning in ip_vs_lblc_check_expire(), > > as reported by syzbot. > > > > Reported-by: <syzbot+3e9695f147fb529aa9bc@syzkaller.appspotmail.com> > > Cc: Simon Horman <horms@verge.net.au> > > Cc: Julian Anastasov <ja@ssi.bg> > > Cc: Pablo Neira Ayuso <pablo@netfilter.org> > > Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com> > > Thanks! > > Acked-by: Julian Anastasov <ja@ssi.bg> Thanks. Pablo, could you take this into nf? Acked-by: Simon Horman <horms@verge.net.au> > > > --- > > net/netfilter/ipvs/ip_vs_lblc.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/net/netfilter/ipvs/ip_vs_lblc.c b/net/netfilter/ipvs/ip_vs_lblc.c > > index 3057e453bf31..83918119ceb8 100644 > > --- a/net/netfilter/ipvs/ip_vs_lblc.c > > +++ b/net/netfilter/ipvs/ip_vs_lblc.c > > @@ -371,6 +371,7 @@ static int ip_vs_lblc_init_svc(struct ip_vs_service *svc) > > tbl->counter = 1; > > tbl->dead = false; > > tbl->svc = svc; > > + atomic_set(&tbl->entries, 0); > > > > /* > > * Hook periodic timer for garbage collection > > -- > > 2.13.0 > > Regards > > -- > Julian Anastasov <ja@ssi.bg> > -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Apr 26, 2018 at 02:14:36PM +0200, Simon Horman wrote: > On Tue, Apr 24, 2018 at 08:17:06AM +0300, Julian Anastasov wrote: > > > > Hello, > > > > On Mon, 23 Apr 2018, Cong Wang wrote: > > > > > Similarly, tbl->entries is not initialized after kmalloc(), > > > therefore causes an uninit-value warning in ip_vs_lblc_check_expire(), > > > as reported by syzbot. > > > > > > Reported-by: <syzbot+3e9695f147fb529aa9bc@syzkaller.appspotmail.com> > > > Cc: Simon Horman <horms@verge.net.au> > > > Cc: Julian Anastasov <ja@ssi.bg> > > > Cc: Pablo Neira Ayuso <pablo@netfilter.org> > > > Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com> > > > > Thanks! > > > > Acked-by: Julian Anastasov <ja@ssi.bg> > > Thanks. > > Pablo, could you take this into nf? > > Acked-by: Simon Horman <horms@verge.net.au> Done, thanks. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/netfilter/ipvs/ip_vs_lblc.c b/net/netfilter/ipvs/ip_vs_lblc.c index 3057e453bf31..83918119ceb8 100644 --- a/net/netfilter/ipvs/ip_vs_lblc.c +++ b/net/netfilter/ipvs/ip_vs_lblc.c @@ -371,6 +371,7 @@ static int ip_vs_lblc_init_svc(struct ip_vs_service *svc) tbl->counter = 1; tbl->dead = false; tbl->svc = svc; + atomic_set(&tbl->entries, 0); /* * Hook periodic timer for garbage collection
Similarly, tbl->entries is not initialized after kmalloc(), therefore causes an uninit-value warning in ip_vs_lblc_check_expire(), as reported by syzbot. Reported-by: <syzbot+3e9695f147fb529aa9bc@syzkaller.appspotmail.com> Cc: Simon Horman <horms@verge.net.au> Cc: Julian Anastasov <ja@ssi.bg> Cc: Pablo Neira Ayuso <pablo@netfilter.org> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com> --- net/netfilter/ipvs/ip_vs_lblc.c | 1 + 1 file changed, 1 insertion(+)