From patchwork Mon Apr 23 20:53:41 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cong Wang X-Patchwork-Id: 903165 X-Patchwork-Delegate: pablo@netfilter.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netfilter-devel-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="kwwrsRJB"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40VJbX4RzRz9rx7 for ; Tue, 24 Apr 2018 06:54:00 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932191AbeDWUx7 (ORCPT ); Mon, 23 Apr 2018 16:53:59 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:41087 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752086AbeDWUx6 (ORCPT ); Mon, 23 Apr 2018 16:53:58 -0400 Received: by mail-pg0-f68.google.com with SMTP id m21so6194485pgv.8; Mon, 23 Apr 2018 13:53:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=R+dJr5g4SUMwgnuPLLZS7MrlsSoSkxBZ1XeFnhbXIpo=; b=kwwrsRJBgAUGv+uOeKf3/PTWON21KV90Dbp4EmweNo0k0NxbMCZiX6A+rAgVosDmWt qznT/1uzObDWOCLaYbvbK5ETnXCeZ88ulQAn0pDtEcjCGD2iLUrCVLF6+4bbCzFhKJfh M/mLZJbRhxCGuYhb+YSVRQ2vXWLgYRWiM8pMh21CultMzfQpuobKJaHy7C0DR5RGbV4Z hbIvAZ+cOJmC6mTlKfxNIkWZdDR/U3XNtDP+Kd+ttfNatK/0zQALojD8+2Xp4dKvbsns hVj9iISxcedEOn8jcUaRrcoa3YObVg2jxgLlPS1yglJlaqMI1CpUZS24xm2c4vAunoUf xMkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=R+dJr5g4SUMwgnuPLLZS7MrlsSoSkxBZ1XeFnhbXIpo=; b=W4iqaV3vuejJ1Jmy8PAkZCzJoSL+deOZE5lSPt82WtLfnSuM3TltO7L+K67pyKDzMX qYaU6Zjd6DYkwhfEUNGEF4rKeOtuHMVkwnXCGddhK+u34FbMZHy2QQmqqJq/ze5o/qqK 2BkfzKM2++t6+h7Nqf1zp0wZTHS+I0BqewsWbCwHEwOqlSEb+Q4ksi0CyYQFRZGCX+G+ 09wG7k7B0wN+afIZ1K/RJ6JPlJ8g/D8VCIc2pBo9skiq3ya1uGeBIO13W/OM/+DKFXf3 AjA065/qjaxibNwR1Abp664b3rxJI2WQIkfrixY4MNkzf/PrqAClCqVWZHhG7siR89bS rXWA== X-Gm-Message-State: ALQs6tD2JrgIFZpwuaYA0c3U5kuP7pr2wfBZhTu3Pnw9OfRp2QZE6pJS CHfRN8FoYlPU1wvSGoqj0Sou/9fk X-Google-Smtp-Source: AIpwx49is8xK6tPudNPzv3+3xtpwd9Kbvpy+1iAjsd45c5ZVUV0O1gWBnWltvkaCukg67vRRcqttCQ== X-Received: by 2002:a17:902:bc8b:: with SMTP id bb11-v6mr18600482plb.285.1524516837680; Mon, 23 Apr 2018 13:53:57 -0700 (PDT) Received: from tw-172-25-29-37.office.twttr.net ([8.25.197.25]) by smtp.gmail.com with ESMTPSA id v16sm24524965pfl.14.2018.04.23.13.53.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Apr 2018 13:53:56 -0700 (PDT) From: Cong Wang To: netdev@vger.kernel.org Cc: lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org, Cong Wang , Simon Horman , Julian Anastasov , Pablo Neira Ayuso Subject: [Patch nf] ipvs: initialize tbl->entries after allocation Date: Mon, 23 Apr 2018 13:53:41 -0700 Message-Id: <20180423205341.13142-1-xiyou.wangcong@gmail.com> X-Mailer: git-send-email 2.9.4 Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org tbl->entries is not initialized after kmalloc(), therefore causes an uninit-value warning in ip_vs_lblc_check_expire() as reported by syzbot. Reported-by: Cc: Simon Horman Cc: Julian Anastasov Cc: Pablo Neira Ayuso Signed-off-by: Cong Wang Acked-by: Julian Anastasov Acked-by: Simon Horman --- net/netfilter/ipvs/ip_vs_lblcr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/netfilter/ipvs/ip_vs_lblcr.c b/net/netfilter/ipvs/ip_vs_lblcr.c index 92adc04557ed..bc2bc5eebcb8 100644 --- a/net/netfilter/ipvs/ip_vs_lblcr.c +++ b/net/netfilter/ipvs/ip_vs_lblcr.c @@ -534,6 +534,7 @@ static int ip_vs_lblcr_init_svc(struct ip_vs_service *svc) tbl->counter = 1; tbl->dead = false; tbl->svc = svc; + atomic_set(&tbl->entries, 0); /* * Hook periodic timer for garbage collection