From patchwork Thu Apr 19 13:31:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pablo Neira Ayuso X-Patchwork-Id: 901133 X-Patchwork-Delegate: pablo@netfilter.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netfilter-devel-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=netfilter.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40RgBH6rfZz9s3L for ; Thu, 19 Apr 2018 23:41:27 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752209AbeDSNlM (ORCPT ); Thu, 19 Apr 2018 09:41:12 -0400 Received: from mail.us.es ([193.147.175.20]:34540 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752831AbeDSNbn (ORCPT ); Thu, 19 Apr 2018 09:31:43 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 9D1C01B695E for ; Thu, 19 Apr 2018 15:31:07 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 8C779BAC4C for ; Thu, 19 Apr 2018 15:31:07 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 81B1FBAC51; Thu, 19 Apr 2018 15:31:07 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on antivirus1-rhel7.int X-Spam-Level: X-Spam-Status: No, score=-108.2 required=7.5 tests=ALL_TRUSTED,BAYES_50, SMTPAUTH_US2,USER_IN_WHITELIST autolearn=disabled version=3.4.1 Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 409B9BAC4C for ; Thu, 19 Apr 2018 15:31:04 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Thu, 19 Apr 2018 15:31:04 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from salvia.here (static-242-42-24-46.ipcom.comunitel.net [46.24.42.242]) (Authenticated sender: pneira@us.es) by entrada.int (Postfix) with ESMTPA id 168D64265A2F for ; Thu, 19 Apr 2018 15:31:04 +0200 (CEST) X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: netfilter-devel@vger.kernel.org Subject: [PATCH nft 2/2] src: use ibrname and obrname Date: Thu, 19 Apr 2018 15:31:31 +0200 Message-Id: <20180419133131.29024-2-pablo@netfilter.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180419133131.29024-1-pablo@netfilter.org> References: <20180419133131.29024-1-pablo@netfilter.org> X-Virus-Scanned: ClamAV using ClamSMTP Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Legacy tool name is 'brctl' and so the 'br' prefix is already known. If we use ibrname and obrname it looks consistent with iifname and oifname. So let's this instead of ibridgename and obridgename since Florian likes this too. Signed-off-by: Pablo Neira Ayuso --- doc/nft.xml | 8 ++++---- src/meta.c | 4 ++-- src/parser_bison.y | 4 ++-- src/scanner.l | 4 ++-- tests/py/bridge/meta.t | 4 ++-- tests/py/bridge/meta.t.payload | 4 ++-- tests/py/inet/meta.t | 4 ++-- tests/py/ip/meta.t | 4 ++-- 8 files changed, 18 insertions(+), 18 deletions(-) diff --git a/doc/nft.xml b/doc/nft.xml index 47e106900d35..661f632efefe 100644 --- a/doc/nft.xml +++ b/doc/nft.xml @@ -2738,8 +2738,8 @@ filter output icmpv6 type { echo-request, echo-reply } skgid nftrace rtclassid - ibridgename - obridgename + ibrname + obrname pkttype cpu iifgroup @@ -2853,12 +2853,12 @@ filter output icmpv6 type { echo-request, echo-reply } realm - ibridgename + ibrname Input bridge interface name ifname - obridgename + obrname Output bridge interface name ifname diff --git a/src/meta.c b/src/meta.c index f80109641757..3012efa94e24 100644 --- a/src/meta.c +++ b/src/meta.c @@ -413,10 +413,10 @@ static const struct meta_template meta_templates[] = { 1 , BYTEORDER_HOST_ENDIAN), [NFT_META_RTCLASSID] = META_TEMPLATE("rtclassid", &realm_type, 4 * 8, BYTEORDER_HOST_ENDIAN), - [NFT_META_BRI_IIFNAME] = META_TEMPLATE("ibridgename", &ifname_type, + [NFT_META_BRI_IIFNAME] = META_TEMPLATE("ibrname", &ifname_type, IFNAMSIZ * BITS_PER_BYTE, BYTEORDER_HOST_ENDIAN), - [NFT_META_BRI_OIFNAME] = META_TEMPLATE("obridgename", &ifname_type, + [NFT_META_BRI_OIFNAME] = META_TEMPLATE("obrname", &ifname_type, IFNAMSIZ * BITS_PER_BYTE, BYTEORDER_HOST_ENDIAN), [NFT_META_PKTTYPE] = META_TEMPLATE("pkttype", &pkttype_type, diff --git a/src/parser_bison.y b/src/parser_bison.y index 54304bd34f74..f546b9edd42e 100644 --- a/src/parser_bison.y +++ b/src/parser_bison.y @@ -394,8 +394,8 @@ int nft_lex(void *, void *, void *); %token RTCLASSID "rtclassid" %token IBRIPORT "ibriport" %token OBRIPORT "obriport" -%token IBRIDGENAME "ibridgename" -%token OBRIDGENAME "obridgename" +%token IBRIDGENAME "ibrname" +%token OBRIDGENAME "obrname" %token PKTTYPE "pkttype" %token CPU "cpu" %token IIFGROUP "iifgroup" diff --git a/src/scanner.l b/src/scanner.l index 9e8fe00bdc3b..5f21bfd7e5e1 100644 --- a/src/scanner.l +++ b/src/scanner.l @@ -486,9 +486,9 @@ addrstring ({macaddr}|{ip4addr}|{ip6addr}) "nftrace" { return NFTRACE; } "rtclassid" { return RTCLASSID; } "ibriport" { return IBRIPORT; } -"ibridgename" { return IBRIDGENAME; } +"ibrname" { return IBRIDGENAME; } "obriport" { return OBRIPORT; } -"obridgename" { return OBRIDGENAME; } +"obrname" { return OBRIDGENAME; } "pkttype" { return PKTTYPE; } "cpu" { return CPU; } "iifgroup" { return IIFGROUP; } diff --git a/tests/py/bridge/meta.t b/tests/py/bridge/meta.t index ed373677a442..f8710b25f0a7 100644 --- a/tests/py/bridge/meta.t +++ b/tests/py/bridge/meta.t @@ -2,5 +2,5 @@ *bridge;test-bridge;input -meta obridgename "br0";ok;meta obridgename "br0" -meta ibridgename "br0";ok;meta ibridgename "br0" +meta obrname "br0";ok;meta obrname "br0" +meta ibrname "br0";ok;meta ibrname "br0" diff --git a/tests/py/bridge/meta.t.payload b/tests/py/bridge/meta.t.payload index 2728c0a5026d..0f0d101781c1 100644 --- a/tests/py/bridge/meta.t.payload +++ b/tests/py/bridge/meta.t.payload @@ -1,9 +1,9 @@ -# meta obridgename "br0" +# meta obrname "br0" bridge test-bridge input [ meta load bri_oifname => reg 1 ] [ cmp eq reg 1 0x00307262 0x00000000 0x00000000 0x00000000 ] -# meta ibridgename "br0" +# meta ibrname "br0" bridge test-bridge input [ meta load bri_iifname => reg 1 ] [ cmp eq reg 1 0x00307262 0x00000000 0x00000000 0x00000000 ] diff --git a/tests/py/inet/meta.t b/tests/py/inet/meta.t index cfde9f32babe..644a96fdf185 100644 --- a/tests/py/inet/meta.t +++ b/tests/py/inet/meta.t @@ -14,5 +14,5 @@ meta nfproto ipv6 meta l4proto tcp;ok;meta nfproto ipv6 meta l4proto 6 meta nfproto ipv4 counter ip saddr 1.2.3.4;ok meta secpath exists;ok meta secpath missing;ok -meta ibridgename "br0";fail -meta obridgename "br0";fail +meta ibrname "br0";fail +meta obrname "br0";fail diff --git a/tests/py/ip/meta.t b/tests/py/ip/meta.t index c3afae79314c..4db88354463e 100644 --- a/tests/py/ip/meta.t +++ b/tests/py/ip/meta.t @@ -8,5 +8,5 @@ meta l4proto ipv6-icmp icmpv6 type nd-router-advert;ok;icmpv6 type nd-router-adv meta l4proto 58 icmpv6 type nd-router-advert;ok;icmpv6 type nd-router-advert icmpv6 type nd-router-advert;ok -meta ibridgename "br0";fail -meta obridgename "br0";fail +meta ibrname "br0";fail +meta obrname "br0";fail