From patchwork Fri Feb 16 19:18:15 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Taehee Yoo X-Patchwork-Id: 874636 X-Patchwork-Delegate: pablo@netfilter.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netfilter-devel-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="QUm66oKU"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zjk5912qGz9sDB for ; Sat, 17 Feb 2018 06:40:29 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750848AbeBPTkO (ORCPT ); Fri, 16 Feb 2018 14:40:14 -0500 Received: from mail-pl0-f68.google.com ([209.85.160.68]:42995 "EHLO mail-pl0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753368AbeBPTSW (ORCPT ); Fri, 16 Feb 2018 14:18:22 -0500 Received: by mail-pl0-f68.google.com with SMTP id 31so2172269ple.9 for ; Fri, 16 Feb 2018 11:18:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=oOxImc3gFIkOAp/qF2+CU1L/FLrJ2J7hTILN/988WfM=; b=QUm66oKUVQOb+0JvtKVAjKOO2vAv+QKfWTxu7d6T6yf0vf+BOFUPTiLndUmyTFc+sq jU26URwl3lYBRb0S1rwqHz+luYEvcdT8PUKRRah1PN/nFuGfqU4T6K2wbmNyAe+Zz5Rs R6mlggARaiJ70TjWAcXJtZIIJELjKA2npwFiEXelojcH/yCGvoFZ+juLiSftp1uql/A6 nGao0s8oFqIvoNDeDyApx4zNZEgA4yXf43FN+HZTockp89JMdXyyL46XqMeHHl/4237Z IY/dHWyCFu72wqb0LzHd4iNDY6WXdnaem+aHgHqPKB1gJvSZgeYX6ehfk3fQbRA60ADu ekUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=oOxImc3gFIkOAp/qF2+CU1L/FLrJ2J7hTILN/988WfM=; b=dhr5T5FhrM8U072S/th586uYDb55U3htZ8giqwaoA6TmKNA5TlCQJTZ+lkWuP8rjdX nau6IFbrRQqwjuimWGZP4gASy/tiwnwpwyuqi3UFUmYhURKPyqo932kYUU7iRmbFDldI K1K6feWgmeiBShOGihNArlSfbI5lwh/HbTCH66ml6h0r9M8+AhNMxWrtKbPPxtDoWWXf SH6i+eWonTwc9jyD6AW2v7Ylshd7uWbMmvPQsQiWP6UA2gGazSwID+FdV9XmQCWR9N0O lepjZb4FIt0ckSXtBgGUaBvjWUw7c1yF3KnZaojgV4wHJw7xjSTXr10UcQgTJGs1j16I ACYA== X-Gm-Message-State: APf1xPC0aUBQZNDgppF3L0sIhVnEpB3+6YSTQh8Uj6xfo7lzZk9Ztzms cV7qKs0EApPy79+iiS6Jkes= X-Google-Smtp-Source: AH8x224+IQL1f50c2vTV325VuQHsKo4rIXZWK7SXdqxoyJWu/yT/0UTPS4vO1151zFwhaI04RDsUIA== X-Received: by 2002:a17:902:aa89:: with SMTP id d9-v6mr3812783plr.325.1518808702012; Fri, 16 Feb 2018 11:18:22 -0800 (PST) Received: from ap-To-be-filled-by-O-E-M.8.8.8.8 ([125.130.197.10]) by smtp.gmail.com with ESMTPSA id m184sm42852332pfb.57.2018.02.16.11.18.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Feb 2018 11:18:20 -0800 (PST) From: Taehee Yoo To: pablo@netfilter.org, netfilter-devel@vger.kernel.org Cc: ap420073@gmail.com Subject: [PATCH] netfilter: increase IPSTATS_MIB_CSUMERRORS stat Date: Sat, 17 Feb 2018 04:18:15 +0900 Message-Id: <20180216191815.26633-1-ap420073@gmail.com> X-Mailer: git-send-email 2.9.3 Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org In the ip_rcv, IPSTATS_MIB_CSUMERRORS is increased when checksum error is occurred. bridge netfilter routine should increase IPSTATS_MIB_CSUMERRORS. Signed-off-by: Taehee Yoo --- net/bridge/br_netfilter_hooks.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/bridge/br_netfilter_hooks.c b/net/bridge/br_netfilter_hooks.c index 27f1d4f..9b16eaf 100644 --- a/net/bridge/br_netfilter_hooks.c +++ b/net/bridge/br_netfilter_hooks.c @@ -214,7 +214,7 @@ static int br_validate_ipv4(struct net *net, struct sk_buff *skb) iph = ip_hdr(skb); if (unlikely(ip_fast_csum((u8 *)iph, iph->ihl))) - goto inhdr_error; + goto csum_error; len = ntohs(iph->tot_len); if (skb->len < len) { @@ -236,6 +236,8 @@ static int br_validate_ipv4(struct net *net, struct sk_buff *skb) */ return 0; +csum_error: + __IP_INC_STATS(net, IPSTATS_MIB_CSUMERRORS); inhdr_error: __IP_INC_STATS(net, IPSTATS_MIB_INHDRERRORS); drop: