From patchwork Sun Feb 11 10:17:20 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Taehee Yoo X-Patchwork-Id: 871739 X-Patchwork-Delegate: pablo@netfilter.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netfilter-devel-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="AgbYv5eL"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zfPqt4m6bz9sBW for ; Sun, 11 Feb 2018 21:17:30 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752736AbeBKKR3 (ORCPT ); Sun, 11 Feb 2018 05:17:29 -0500 Received: from mail-pg0-f66.google.com ([74.125.83.66]:40300 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752288AbeBKKR2 (ORCPT ); Sun, 11 Feb 2018 05:17:28 -0500 Received: by mail-pg0-f66.google.com with SMTP id g2so5776686pgn.7 for ; Sun, 11 Feb 2018 02:17:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=BgKetjiZ3rV+stUV2Z270TvPFkgAI7OZETPpLHgtcSE=; b=AgbYv5eLb3KTfXaH52XD+ZdBFiexFpqFlJCNJgdx+WSOO8RUHj5ctG2w7GgcouSEtJ BlPmaQywLLkN+975S8PMiW0BhyGUE1wbd1jsYKxrHSRNWxqqNDZbJ8s64lBcXj0/W1Vf PxsWLhgqO7KPItDTsluzucKbvkxTq0TFwKnbnttDuTK+vTxtNQ2sGiufwwcjr3GjK+2n 0QJyhrwVSwkqHbF0vHDOAWfn+SS2zsN9yhigVEzJp6Ybi3HcgcLhX6tsoqCRuR/w/sRA 4s9rkZfHJRLge3Tki1xLjfWuJwecWcvl1+hBNVyObgBkvSt90RMXK78KwQre5CAKGzaO xbqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=BgKetjiZ3rV+stUV2Z270TvPFkgAI7OZETPpLHgtcSE=; b=BqWShkbJgEJEUWYregZYTsvew24P6Tq0u6wfABk6GtDMRl83GtVCwzZQrYOhFlx4UR couYEoGW9OGG/cozwTWEEMxzDTxaBw59TeXDoDdX1UAKAvfhaGAvTlCvC5Tta6VfZcAl q0urVDZpkdfGf5Mk8aBWWW1gkkFYNhfqLPm6E+m7mtGLbDUicjBa25pSGmS01vUrSWPg 06XWi61esgCYtsQMgI1SM2mFVtcCQf8HPh7FojwLW7PF8S2T3OEoW/qTvyHU5RNHOn5G gYDOkNdjPinyEMW5MsacPsoeOgfKsnwdVSVAoSc68ARR9dyMe6NsgFKkjiZdtxR5aa7E 3BKw== X-Gm-Message-State: APf1xPANrbaO9eiCmwo3eeJZIPoMq2igC2mjuMQJROP7u8c73ye5jyWM 1LzWX8zaz5BFZe4+DIOHJfk= X-Google-Smtp-Source: AH8x2243fEECncmagSkdjLOos/fLwo1dnlvQVOCba1+KkasCMZLedW8NOwvxEsMTHO38czMOJ2tjSQ== X-Received: by 10.99.163.9 with SMTP id s9mr6859867pge.264.1518344248392; Sun, 11 Feb 2018 02:17:28 -0800 (PST) Received: from ap-To-be-filled-by-O-E-M.8.8.8.8 ([125.130.197.10]) by smtp.gmail.com with ESMTPSA id t1sm15805400pgu.77.2018.02.11.02.17.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 11 Feb 2018 02:17:27 -0800 (PST) From: Taehee Yoo To: pablo@netfilter.org, netfilter-devel@vger.kernel.org Cc: ap420073@gmail.com Subject: [PATCH] netfilter: nfnetlink_acct: remove useless parameter Date: Sun, 11 Feb 2018 19:17:20 +0900 Message-Id: <20180211101720.20348-1-ap420073@gmail.com> X-Mailer: git-send-email 2.9.3 Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org parameter skb in nfnl_acct_overquota is not used anywhere. Signed-off-by: Taehee Yoo --- include/linux/netfilter/nfnetlink_acct.h | 3 +-- net/netfilter/nfnetlink_acct.c | 3 +-- net/netfilter/xt_nfacct.c | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/include/linux/netfilter/nfnetlink_acct.h b/include/linux/netfilter/nfnetlink_acct.h index b4d7411..beee8bf 100644 --- a/include/linux/netfilter/nfnetlink_acct.h +++ b/include/linux/netfilter/nfnetlink_acct.h @@ -16,6 +16,5 @@ struct nf_acct; struct nf_acct *nfnl_acct_find_get(struct net *net, const char *filter_name); void nfnl_acct_put(struct nf_acct *acct); void nfnl_acct_update(const struct sk_buff *skb, struct nf_acct *nfacct); -int nfnl_acct_overquota(struct net *net, const struct sk_buff *skb, - struct nf_acct *nfacct); +int nfnl_acct_overquota(struct net *net, struct nf_acct *nfacct); #endif /* _NFNL_ACCT_H */ diff --git a/net/netfilter/nfnetlink_acct.c b/net/netfilter/nfnetlink_acct.c index 88d427f..b9505bc 100644 --- a/net/netfilter/nfnetlink_acct.c +++ b/net/netfilter/nfnetlink_acct.c @@ -467,8 +467,7 @@ static void nfnl_overquota_report(struct net *net, struct nf_acct *nfacct) GFP_ATOMIC); } -int nfnl_acct_overquota(struct net *net, const struct sk_buff *skb, - struct nf_acct *nfacct) +int nfnl_acct_overquota(struct net *net, struct nf_acct *nfacct) { u64 now; u64 *quota; diff --git a/net/netfilter/xt_nfacct.c b/net/netfilter/xt_nfacct.c index cc0518f..9c2719c 100644 --- a/net/netfilter/xt_nfacct.c +++ b/net/netfilter/xt_nfacct.c @@ -26,7 +26,7 @@ static bool nfacct_mt(const struct sk_buff *skb, struct xt_action_param *par) nfnl_acct_update(skb, info->nfacct); - overquota = nfnl_acct_overquota(xt_net(par), skb, info->nfacct); + overquota = nfnl_acct_overquota(xt_net(par), info->nfacct); return overquota == NFACCT_UNDERQUOTA ? false : true; }