From patchwork Thu Nov 23 18:55:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harsha Sharma X-Patchwork-Id: 840874 X-Patchwork-Delegate: pablo@netfilter.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netfilter-devel-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="UqHBHL2i"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yjT6q0kvnz9s71 for ; Fri, 24 Nov 2017 05:55:47 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753246AbdKWSzq (ORCPT ); Thu, 23 Nov 2017 13:55:46 -0500 Received: from mail-pl0-f54.google.com ([209.85.160.54]:39147 "EHLO mail-pl0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753195AbdKWSzp (ORCPT ); Thu, 23 Nov 2017 13:55:45 -0500 Received: by mail-pl0-f54.google.com with SMTP id l16so3086568pli.6 for ; Thu, 23 Nov 2017 10:55:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=LoCNM9cxURDsR8z3ufSJQDAa6q8gcFMx5COZpRg1+M4=; b=UqHBHL2iT8odAt7tGf/qw+IEUHXDjncZ/Y7AGFCdQ9yTxtNRBRR0pG+a1CHHToidgw TVhxBu7HXHdEqE5Wls/dchluFT2C+e3jsxoaIRD9Zo9EPkEkfYRBXPp1XF3LHKdCBe+i X1Ofcp7nQFGKLfzEXxuKgs5u6dRVMpFUxzZZBJIFPZTa5jSLDP+xTSzD1PIYSVefekbY 8EvdtfOCiGjQgXIxeCbmU6c5BrugvQ/iC9rZ4V8WWlkB4JwJp0YIbDHXPHHmYAIfUI4p 2u736iOnuqpbQhGYoIIoICSsDRkEhxUN3MxXPq7UhBt8mQEl1ZV66vYFq1+SX6ybe54w 5fLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=LoCNM9cxURDsR8z3ufSJQDAa6q8gcFMx5COZpRg1+M4=; b=Q/HstJEdumZ33zxnuGne4MmW8EIMjZ8TZVjn0NfQIYWveZa0QDYQy5E+ke15LL/HSC gQbkF9mwCmn1xAsPU6g3AWU1e1xqCLjgB5uuM5GF3t5gJ4VGzA1ukHACBILqbaYqEas0 HLhQvEHbtlBEmWHfq+usOTON0DiQhZ9VmRDFVZcuNsVEXCBXwLRXB8W3rOh8Ol7wp2j4 fQnktXCiatPuCRpQIYKURAcuIt4Nv/pwgbFA1JJbh/LygS84CqoOfcT2rri21LzMKNc/ JclsII7IhDp8ywz7PVcYApAIbNKTRnZ+B10Eri5f69H0EzjnKSKPgKGaw9CdGPjDJuI/ LkOQ== X-Gm-Message-State: AJaThX7jZGdBc94qGOnT0CWQIy5N34FHs7VwbVCTtiVddQW7u3Rt13Fi 5qpSKov5jmS9GlUqvhOv7S2MhA== X-Google-Smtp-Source: AGs4zMYCH5wwUmXwDXUK1WxTdQWIy6dqzR9KpIX+XfIvLuIIVy1pwQGZPFd6+o9avIhnPTxpEIwc/w== X-Received: by 10.84.233.1 with SMTP id j1mr6473010plk.311.1511463344985; Thu, 23 Nov 2017 10:55:44 -0800 (PST) Received: from localhost.localdomain ([103.37.201.27]) by smtp.gmail.com with ESMTPSA id 76sm35417448pfn.179.2017.11.23.10.55.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Nov 2017 10:55:44 -0800 (PST) From: Harsha Sharma To: pablo@netfilter.org Cc: netfilter-devel@vger.kernel.org, Harsha Sharma Subject: [PATCH] evaluate: print error for null string befort assert statement Date: Fri, 24 Nov 2017 00:25:14 +0530 Message-Id: <20171123185514.16711-1-harshasharmaiitr@gmail.com> X-Mailer: git-send-email 2.11.0 Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Print error "Null string is not allowed" before assert statement. For e.g. nft add rule filter input meta iifname '""' Error: Null String is not allowed add rule filter input meta iifname "" Signed-off-by: Harsha Sharma --- src/evaluate.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/evaluate.c b/src/evaluate.c index fd61e75..ad044a4 100644 --- a/src/evaluate.c +++ b/src/evaluate.c @@ -235,6 +235,10 @@ static int expr_evaluate_string(struct eval_ctx *ctx, struct expr **exprp) memset(data + len, 0, data_len - len); mpz_export_data(data, expr->value, BYTEORDER_HOST_ENDIAN, len); + if (strlen(data) == 0) { + return expr_error(ctx->msgs, expr, + "Null String is not allowed"); + } assert(strlen(data) > 0); datalen = strlen(data) - 1; if (data[datalen] != '*') {