diff mbox series

[iptables,1/2] ip{,6}tables-restore: Don't ignore missing wait-interval value

Message ID 20170920173436.20221-2-phil@nwl.cc
State Accepted
Delegated to: Pablo Neira
Headers show
Series ip{,6}tables-restore: Fix wait-interval parsing | expand

Commit Message

Phil Sutter Sept. 20, 2017, 5:34 p.m. UTC 
Passing -W without a value doesn't make sense so bail out if none was
given.

Signed-off-by: Phil Sutter <phil@nwl.cc>
---
 iptables/xshared.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/iptables/xshared.c b/iptables/xshared.c
index 825479c338214..06db72d427e21 100644
--- a/iptables/xshared.c
+++ b/iptables/xshared.c
@@ -343,7 +343,7 @@  void parse_wait_interval(int argc, char *argv[], struct timeval *wait_interval)
 	else if (xs_has_arg(argc, argv))
 		arg = argv[optind++];
 	else
-		return;
+		xtables_error(PARAMETER_PROBLEM, "wait interval value required");
 
 	ret = sscanf(arg, "%u", &usec);
 	if (ret == 1) {