| Message ID | 20170824160418.19507-1-phil@nwl.cc |
|---|---|
| State | Accepted |
| Delegated to: | Pablo Neira |
| Headers | show |
On Thu, Aug 24, 2017 at 06:04:18PM +0200, Phil Sutter wrote: > Debug mask check was done against wrong flag, causing protocol context > debug output being printed when only --debug=netlink was given. Applied. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/src/proto.c b/src/proto.c index 5bd50b7b96195..a72c10c3a1680 100644 --- a/src/proto.c +++ b/src/proto.c @@ -143,7 +143,7 @@ static void proto_ctx_debug(const struct proto_ctx *ctx, enum proto_bases base, { unsigned int i; - if (!(debug_mask & DEBUG_NETLINK)) + if (!(debug_mask & DEBUG_PROTO_CTX)) return; pr_debug("update %s protocol context:\n", proto_base_names[base]);
Debug mask check was done against wrong flag, causing protocol context debug output being printed when only --debug=netlink was given. Fixes: be441e1ffdc24 ("src: add debugging mask to context structure") Signed-off-by: Phil Sutter <phil@nwl.cc> --- This led to almost all testcases in tests/py to fail due to differing output when checking netlink messages. Pablo, did you just forget to run the testsuite, or is there a bug in your environment somewhere so this could slip through? --- src/proto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)