| Message ID | 20170710223255.29885-4-eric@regit.org |
|---|---|
| State | Accepted |
| Delegated to: | Pablo Neira |
| Headers | show |
diff --git a/src/parser_bison.y b/src/parser_bison.y index c505a04..b898e1c 100644 --- a/src/parser_bison.y +++ b/src/parser_bison.y @@ -1089,7 +1089,8 @@ list_cmd : TABLE table_spec if (erec != NULL) { erec_queue(erec, state->msgs); YYERROR; - } + } else + YYERROR; } $$ = cmd_alloc(CMD_LIST, cmd, &$4, &@$, NULL);
We had the following warnings parser_bison.y:1089:10: warning: variable 'cmd' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] if (erec != NULL) { ^~~~~~~~~~~~ parser_bison.y:1095:39: note: uninitialized use occurs here (yyval.cmd) = cmd_alloc(CMD_LIST, cmd, &(yyvsp[0].handle), &(yyloc), NULL); ^~~ parser_bison.y:1089:6: note: remove the 'if' if its condition is always true if (erec != NULL) { ^~~~~~~~~~~~~~~~~~ parser_bison.y:1080:12: note: initialize the variable 'cmd' to silence this warning int cmd; ^ = 0 Signed-off-by: Eric Leblond <eric@regit.org> --- src/parser_bison.y | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)