| Message ID | 20170127203847.10785-1-cernekee@chromium.org |
|---|---|
| State | Accepted |
| Delegated to: | Pablo Neira |
| Headers | show |
On Fri, Jan 27, 2017 at 12:38:46PM -0800, Kevin Cernekee wrote: > According to valgrind, this currently leaks ~512B to 2kB for each > packet sent to the userspace helper. Applied, thanks! -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/src/cthelper.c b/src/cthelper.c index 54eb830..f01c509 100644 --- a/src/cthelper.c +++ b/src/cthelper.c @@ -325,6 +325,7 @@ static int nfq_queue_cb(const struct nlmsghdr *nlh, void *data) if (pkt_verdict_issue(helper, myct, queue_num, id, verdict, pktb) < 0) goto err4; + pktb_free(pktb); nfct_destroy(ct); if (myct->exp != NULL) nfexp_destroy(myct->exp);
According to valgrind, this currently leaks ~512B to 2kB for each packet sent to the userspace helper. Signed-off-by: Kevin Cernekee <cernekee@chromium.org> --- src/cthelper.c | 1 + 1 file changed, 1 insertion(+)