| Message ID | 20160316221749.GA4613@sonyv |
|---|---|
| State | Accepted |
| Delegated to: | Pablo Neira |
| Headers | show |
On Wed, Mar 16, 2016 at 11:17:52PM +0100, Laura Garcia Liebana wrote: > Avoid to print the reject with value in the translation when the value > is the default. > > Before this patch: > > $ sudo ip6tables-translate -A FORWARD -p TCP --dport 22 -j REJECT > nft add rule ip6 filter FORWARD tcp dport 22 counter reject with icmpv6 type port-unreachable > > After this patch: > > $ sudo ip6tables-translate -A FORWARD -p TCP --dport 22 -j REJECT > nft add rule ip6 filter FORWARD tcp dport 22 counter reject Also applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/extensions/libip6t_REJECT.c b/extensions/libip6t_REJECT.c index c30f292..5fa551e 100644 --- a/extensions/libip6t_REJECT.c +++ b/extensions/libip6t_REJECT.c @@ -149,7 +149,10 @@ static int REJECT_xlate(const void *ip, const struct xt_entry_target *target, for (i = 0; i < ARRAY_SIZE(reject_table_xlate); ++i) if (reject_table_xlate[i].with == reject->with) break; - if (reject->with == IP6T_TCP_RESET) + + if (reject->with == IP6T_ICMP6_PORT_UNREACH) + xt_xlate_add(xl, "reject"); + else if (reject->with == IP6T_TCP_RESET) xt_xlate_add(xl, "reject with %s", reject_table_xlate[i].name); else xt_xlate_add(xl, "reject with icmpv6 type %s",
Avoid to print the reject with value in the translation when the value is the default. Before this patch: $ sudo ip6tables-translate -A FORWARD -p TCP --dport 22 -j REJECT nft add rule ip6 filter FORWARD tcp dport 22 counter reject with icmpv6 type port-unreachable After this patch: $ sudo ip6tables-translate -A FORWARD -p TCP --dport 22 -j REJECT nft add rule ip6 filter FORWARD tcp dport 22 counter reject Signed-off-by: Laura Garcia Liebana <nevola@gmail.com> --- v2: - Remove default constant, as Pablo suggested. extensions/libip6t_REJECT.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)