From patchwork Sun Feb 28 19:40:43 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shivani Bhardwaj X-Patchwork-Id: 589625 X-Patchwork-Delegate: pablo@netfilter.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3AE1614076B for ; Mon, 29 Feb 2016 06:40:53 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=FMzIv9hg; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754675AbcB1Tkw (ORCPT ); Sun, 28 Feb 2016 14:40:52 -0500 Received: from mail-pf0-f177.google.com ([209.85.192.177]:34375 "EHLO mail-pf0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754612AbcB1Tkv (ORCPT ); Sun, 28 Feb 2016 14:40:51 -0500 Received: by mail-pf0-f177.google.com with SMTP id 4so1176840pfd.1 for ; Sun, 28 Feb 2016 11:40:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:mime-version:content-disposition :user-agent; bh=mi2aQeeW3Y8/edm+DbGlQQror0dBAPuFixEXfsnNvp0=; b=FMzIv9hgzVKhGfoI3U4nwSjfHe4CgEMR7ffUfaJHBF6Vbn+pw43OglR78b38wCyh5R mfBwGeuKc2W0NBD9GUDYbbHHK5ZreGeQFOXeF5plXMNZ3VJUI96/6z/uXr3RU+xdlzPt AKikRUdVUsJcMWc7YtcxY5HHbdhWzutJddjzSgkE/9dUlv+KLrdC1P3ZWDREW0CtzzMk frQkrYJhKvcP02YaBNBAvDp/nE9HJ4Xi3cwj8KrL69k0f4/PN43Pl7ah1HOLmGxpcahB Qb3vpTt4h8ZFt2eB3rd2rMqgkeR3C+cvR4iVwLCiV/MUfF5ypQpJzX5TI40uR2BAYCMx 2Ikg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:user-agent; bh=mi2aQeeW3Y8/edm+DbGlQQror0dBAPuFixEXfsnNvp0=; b=IrxdZjih4Fl6n7Oqyyn0Q8qV67eN+B9+5L1Y2Z/uhOv9jmPNauSKCz4DYYJ0R1miXf WZfZQRuwspSxLBQl+NuKvXWUeW/ws0275nUz//h24lrji3TRlvgmGkEBgqCk1cCgUfHq 3gSa8OO30gfnVPZPJpEl/0/1jD1vevJPVLZe7fUufgszaxh/+2M4KNRzEaP6fGANF66X imMZzvKuZaIfDNIMhxCes/6wEjInYLfhHSDEicgu9cqdA/5eJH3YVq0rayJZIzE4X8bJ W51U2aW+OgBRvfl9eJnbI2ivWa1f2PDPeBU+JGxufTOkBfCquPSWaF6mAWKv1v0AbC3+ AN1w== X-Gm-Message-State: AD7BkJKIPBQWlUbtEUwZq6TCMENhLZGqh1kBIKWMQfUqoRJflqDLBGRWICJ0mIWGjUIBYA== X-Received: by 10.98.64.82 with SMTP id n79mr10092757pfa.149.1456688450196; Sun, 28 Feb 2016 11:40:50 -0800 (PST) Received: from gmail.com ([171.50.127.0]) by smtp.gmail.com with ESMTPSA id m5sm32759437pfi.84.2016.02.28.11.40.47 for (version=TLS1_2 cipher=AES128-SHA bits=128/128); Sun, 28 Feb 2016 11:40:49 -0800 (PST) Date: Mon, 29 Feb 2016 01:10:43 +0530 From: Shivani Bhardwaj To: netfilter-devel@vger.kernel.org Subject: [PATCH] src: netlink_delinearize: Fix datatype for len Message-ID: <20160228194043.GA15021@gmail.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Change the data type of len from unsigned int to int in order to make it valid for checks like if (len < 0) The issue was brought into attention by the unexplained behavior of frag with frag-off. Bugzilla entry: https://bugzilla.netfilter.org/show_bug.cgi?id=935 This patch fixes this bug, however there are still issues with frag that need to be fixed. Signed-off-by: Shivani Bhardwaj --- src/netlink_delinearize.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/netlink_delinearize.c b/src/netlink_delinearize.c index ae6abb0..2d7a417 100644 --- a/src/netlink_delinearize.c +++ b/src/netlink_delinearize.c @@ -107,7 +107,7 @@ static void netlink_release_registers(struct netlink_parse_ctx *ctx) static struct expr *netlink_parse_concat_expr(struct netlink_parse_ctx *ctx, const struct location *loc, unsigned int reg, - unsigned int len) + int len) { struct expr *concat, *expr; @@ -134,7 +134,7 @@ err: static struct expr *netlink_parse_concat_data(struct netlink_parse_ctx *ctx, const struct location *loc, unsigned int reg, - unsigned int len, + int len, struct expr *data) { struct expr *concat, *expr, *i;