diff mbox

[conntrack-tools] list: fix prefetch dummy

Message ID 20150820104520.23066.45825.stgit@r2d2.cica.es
State Accepted
Delegated to: Pablo Neira
Headers show

Commit Message

Arturo Borrero Gonzalez Aug. 20, 2015, 10:45 a.m. UTC 
From: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>

[...]
  CC       conntrack.o
In file included from ../include/conntrack.h:4:0,
                 from conntrack.c:41:
conntrack.c: In function ‘findproto’:
../include/linux_list.h:385:59: warning: right-hand operand of comma expression has no effect [-Wunused-value]
  for (pos = list_entry((head)->next, typeof(*pos), member), \
                                                          ^
[...]

The original patch is from Patrick McHardy <kaber@trash.net>.

Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
---
 include/linux_list.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Pablo Neira Ayuso Aug. 26, 2015, 6:45 p.m. UTC | #1 
On Thu, Aug 20, 2015 at 12:45:20PM +0200, Arturo Borrero Gonzalez wrote:
> From: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
> 
> [...]
>   CC       conntrack.o
> In file included from ../include/conntrack.h:4:0,
>                  from conntrack.c:41:
> conntrack.c: In function ‘findproto’:
> ../include/linux_list.h:385:59: warning: right-hand operand of comma expression has no effect [-Wunused-value]
>   for (pos = list_entry((head)->next, typeof(*pos), member), \
>                                                           ^
> [...]

Thanks for taking care of this, Arturo.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/include/linux_list.h b/include/linux_list.h
index de182a4..efffb91 100644
--- a/include/linux_list.h
+++ b/include/linux_list.h
@@ -29,7 +29,7 @@ 
 	1; \
 })
 
-#define prefetch(x)		1
+#define prefetch(x)		((void)0)
 
 /* empty define to make this work in userspace -HW */
 #ifndef smp_wmb