From patchwork Mon Jan 6 18:36:33 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Miller X-Patchwork-Id: 307412 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 449722C00BC for ; Tue, 7 Jan 2014 05:36:39 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755846AbaAFSgg (ORCPT ); Mon, 6 Jan 2014 13:36:36 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:33150 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755101AbaAFSgf (ORCPT ); Mon, 6 Jan 2014 13:36:35 -0500 Received: from localhost (nat-pool-rdu-t.redhat.com [66.187.233.202]) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id C6A68587C47; Mon, 6 Jan 2014 10:36:34 -0800 (PST) Date: Mon, 06 Jan 2014 13:36:33 -0500 (EST) Message-Id: <20140106.133633.333909371095279469.davem@davemloft.net> To: eric.dumazet@gmail.com Cc: pablo@netfilter.org, valentina.giusti@bmw-carit.de, netfilter-devel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 03/12] netfilter: nfnetlink_queue: enable UID/GID socket info retrieval From: David Miller In-Reply-To: <1389022353.12212.176.camel@edumazet-glaptop2.roam.corp.google.com> References: <1388963586-5049-1-git-send-email-pablo@netfilter.org> <1388963586-5049-4-git-send-email-pablo@netfilter.org> <1389022353.12212.176.camel@edumazet-glaptop2.roam.corp.google.com> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.1 (shards.monkeyblade.net [0.0.0.0]); Mon, 06 Jan 2014 10:36:35 -0800 (PST) Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org From: Eric Dumazet Date: Mon, 06 Jan 2014 07:32:33 -0800 > net/netfilter/nfnetlink_queue_core.c: In function 'nfqnl_put_sk_uidgid': > net/netfilter/nfnetlink_queue_core.c:304:35: error: 'TCP_TIME_WAIT' undeclared (first use in this function) > net/netfilter/nfnetlink_queue_core.c:304:35: note: each undeclared identifier is reported only once for each function it appears in > make[3]: *** [net/netfilter/nfnetlink_queue_core.o] Error 1 > > Fix is obvious (#include ), but I have to run... I just committed the following: ==================== [PATCH] netfilter: Fix build failure in nfnetlink_queue_core.c. net/netfilter/nfnetlink_queue_core.c: In function 'nfqnl_put_sk_uidgid': net/netfilter/nfnetlink_queue_core.c:304:35: error: 'TCP_TIME_WAIT' undeclared (first use in this function) net/netfilter/nfnetlink_queue_core.c:304:35: note: each undeclared identifier is reported only once for each function it appears in make[3]: *** [net/netfilter/nfnetlink_queue_core.o] Error 1 Just a missing include of net/tcp_states.h Reported-by: Eric Dumazet Signed-off-by: David S. Miller --- net/netfilter/nfnetlink_queue_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/netfilter/nfnetlink_queue_core.c b/net/netfilter/nfnetlink_queue_core.c index d3cf12b..b5e1f82 100644 --- a/net/netfilter/nfnetlink_queue_core.c +++ b/net/netfilter/nfnetlink_queue_core.c @@ -29,6 +29,7 @@ #include #include #include +#include #include #include #include