| Message ID | 1952176.MYFl3FrgUH@storm |
|---|---|
| State | Accepted |
| Headers | show |
diff --git a/lib/parse.c b/lib/parse.c index 550048c..d06e9cd 100644 --- a/lib/parse.c +++ b/lib/parse.c @@ -445,8 +445,8 @@ ipset_parse_proto(struct ipset_session *session, uint8_t protonum; int err; - if (!((err = string_to_u8(session, str, &protonum) == 0) && - (protoent = getprotobynumber(protonum)) != NULL)) + if (!((err = string_to_u8(session, str, &protonum)) == 0) && + (protoent = getprotobynumber(protonum)) != NULL) return syntax_err("cannot parse '%s' " "as a protocol", str); }
cppcheck (vaguely) reported: [lib/parse.c:448]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses. Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com> --- lib/parse.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)