diff mbox series

[1/2] iptables: tests: shell: Add README

Message ID 1530178540-4120-1-git-send-email-arushisinghal19971997@gmail.com
State Changes Requested
Delegated to: Florian Westphal
Headers show
Series [1/2] iptables: tests: shell: Add README | expand

Commit Message

Arushi Singhal June 28, 2018, 9:35 a.m. UTC
README added

Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
 iptables/tests/shell/README | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 iptables/tests/shell/README

Comments

Florian Westphal June 28, 2018, 9:43 a.m. UTC | #1
Arushi Singhal <arushisinghal19971997@gmail.com> wrote:
> README added

Sorry, you will need to rebase this on top of current iptables.git
master.

> +Before each call to the test-files, `kernel_cleanup' will be called.

I removed 'kernel_cleanup' in favor of running tests in a temporary
netns.

> +Also, test-files will receive the environment variable $IPTABLES which
> +contains the path to the iptables binary being tested.

I removed that as well, scripts get passed $XTABLES_MULTI instead.
So a script now needs to do

$XTABLES_MULTI iptables -N c1
or
$XTABLES_MULTI ip6tables -N c1

(or use iptables-save, restore, ebtables, etc)

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jan Engelhardt June 28, 2018, 11:37 a.m. UTC | #2
On Thursday 2018-06-28 11:35, Arushi Singhal wrote:

>README added
>
>Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
>---
> iptables/tests/shell/README | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
> create mode 100644 iptables/tests/shell/README
>
>diff --git a/iptables/tests/shell/README b/iptables/tests/shell/README
>new file mode 100644
>index 0000000..fb3a21a
>--- /dev/null
>+++ b/iptables/tests/shell/README
>@@ -0,0 +1,20 @@
>+To run the test suite (as root):
>+ % cd iptables/tests/shell
>+ % ./run-tests.sh

IIRC, % was historically used to indicate csh. So maybe $, or, since 
it's supposed to be as root, just #?
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox series

Patch

diff --git a/iptables/tests/shell/README b/iptables/tests/shell/README
new file mode 100644
index 0000000..fb3a21a
--- /dev/null
+++ b/iptables/tests/shell/README
@@ -0,0 +1,20 @@ 
+To run the test suite (as root):
+ % cd iptables/tests/shell
+ % ./run-tests.sh
+    
+Test files are executables files with the pattern <<name_N>> , where
+N is the expected return code of the executable. Since they are
+located with `find', test-files can be spreaded in any sub-directories.
+    
+You can turn on a verbose execution by calling:
+ % ./run-tests.sh -v
+
+And to run test suite for pariticular test files:
+ % ./run-tests.sh <PATH_OF_TESTFILES>
+
+Before each call to the test-files, `kernel_cleanup' will be called.
+Also, test-files will receive the environment variable $IPTABLES which
+contains the path to the iptables binary being tested.
+    
+You can pass an arbitrary $IPTABLES value as well:
+ % IPTABLES=/../../xtables-multi iptables ./run-tests.sh