From patchwork Sat Jan 7 13:33:55 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liping Zhang X-Patchwork-Id: 712265 X-Patchwork-Delegate: pablo@netfilter.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3twj860bjyz9sCg for ; Sun, 8 Jan 2017 00:34:46 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=163.com header.i=@163.com header.b="pBsNPAe1"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932938AbdAGNep (ORCPT ); Sat, 7 Jan 2017 08:34:45 -0500 Received: from m12-17.163.com ([220.181.12.17]:51360 "EHLO m12-17.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932596AbdAGNep (ORCPT ); Sat, 7 Jan 2017 08:34:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=JQIPcF5UC1iLA92pLX j1snIwg5WQhKnaFem2qHimYPQ=; b=pBsNPAe1thndYOhm0yfLwJwVB0301hEePB RWnVyuxbb+HUah3mna3JeOO33bPihM8ob2MLsn5Gc3OVkAfdBK5AL7OoVHC8+h9u e+BxirSEOiUxwoIadMM5UuLMgK550pyBzbOANlYSv+DY/hrYa5uo459ChUdFIy6p Rt4meBRuY= Received: from MiWiFi-R2D-srv.localdomain (unknown [180.164.152.86]) by smtp13 (Coremail) with SMTP id EcCowAA34_xW7nBY6fo_GA--.52407S3; Sat, 07 Jan 2017 21:34:34 +0800 (CST) From: Liping Zhang To: pablo@netfilter.org Cc: netfilter-devel@vger.kernel.org, Liping Zhang Subject: [PATCH nf-next 2/2] netfilter: nft_meta: deal with PACKET_LOOPBACK in netdev family Date: Sat, 7 Jan 2017 21:33:55 +0800 Message-Id: <1483796035-54792-2-git-send-email-zlpnobody@163.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1483796035-54792-1-git-send-email-zlpnobody@163.com> References: <1483796035-54792-1-git-send-email-zlpnobody@163.com> X-CM-TRANSID: EcCowAA34_xW7nBY6fo_GA--.52407S3 X-Coremail-Antispam: 1Uf129KBjvJXoW7AFy3GFW5Gr48tFyrJr17GFg_yoW8AF4xpF WrGws3J3s7WrW3tw1fKFy8Aw15Ga18tw4Uurs3Jwn5ZFs8GFs8K3WxKryDWF1DCFZFy3y5 JFna9r1DCa98ZrJanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jF6wZUUUUU= X-Originating-IP: [180.164.152.86] X-CM-SenderInfo: x2os00perg5qqrwthudrp/1tbiVAlYl1UL+9U3VwAAsC Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org From: Liping Zhang After adding the following nft rule, then ping 224.0.0.1: # nft add rule netdev t c pkttype host counter The warning complain message will be printed out again and again: WARNING: CPU: 0 PID: 10182 at net/netfilter/nft_meta.c:163 \ nft_meta_get_eval+0x3fe/0x460 [nft_meta] [...] Call Trace: dump_stack+0x85/0xc2 __warn+0xcb/0xf0 warn_slowpath_null+0x1d/0x20 nft_meta_get_eval+0x3fe/0x460 [nft_meta] nft_do_chain+0xff/0x5e0 [nf_tables] So we should deal with PACKET_LOOPBACK in netdev family too. For ipv4, convert it to PACKET_BROADCAST/MULTICAST according to the destination address's type; For ipv6, convert it to PACKET_MULTICAST directly. Signed-off-by: Liping Zhang --- net/netfilter/nft_meta.c | 28 +++++++++++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/net/netfilter/nft_meta.c b/net/netfilter/nft_meta.c index 9a22b24..e1f5ca9 100644 --- a/net/netfilter/nft_meta.c +++ b/net/netfilter/nft_meta.c @@ -156,8 +156,34 @@ void nft_meta_get_eval(const struct nft_expr *expr, case NFPROTO_IPV6: *dest = PACKET_MULTICAST; break; + case NFPROTO_NETDEV: + switch (skb->protocol) { + case htons(ETH_P_IP): { + int noff = skb_network_offset(skb); + struct iphdr *iph, _iph; + + iph = skb_header_pointer(skb, noff, + sizeof(_iph), &_iph); + if (!iph) + goto err; + + if (ipv4_is_multicast(iph->daddr)) + *dest = PACKET_MULTICAST; + else + *dest = PACKET_BROADCAST; + + break; + } + case htons(ETH_P_IPV6): + *dest = PACKET_MULTICAST; + break; + default: + WARN_ON_ONCE(1); + goto err; + } + break; default: - WARN_ON(1); + WARN_ON_ONCE(1); goto err; } break;