From patchwork Wed Oct 19 15:29:53 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liping Zhang X-Patchwork-Id: 684205 X-Patchwork-Delegate: pablo@netfilter.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3szbjH2nMyz9vGl for ; Thu, 20 Oct 2016 02:39:47 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=163.com header.i=@163.com header.b=UZhncLIE; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S945131AbcJSPai (ORCPT ); Wed, 19 Oct 2016 11:30:38 -0400 Received: from m12-11.163.com ([220.181.12.11]:44006 "EHLO m12-11.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S945125AbcJSPaf (ORCPT ); Wed, 19 Oct 2016 11:30:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=so0wjx+SyHURBSnsxv sc7fwm7leT5UDd1rT0cr0iJ/o=; b=UZhncLIEO5ijYAo4VuaT9oVCtNPMWSjMne 2EgfN3/YOBhSDFKab+mO8gQXlIGcA3PF0H0Fm/50+xoVMXK1s0Mbc8BKEtbz8vCS J23eTNQclXhy5sOfhZHwF/1WjVFjPECSW62p/AeAG1jZ0LKsFKUvS1nB47jAN3jR Yi5FRd8Kg= Received: from MiWiFi-R2D-srv.localdomain (unknown [180.170.252.41]) by smtp7 (Coremail) with SMTP id C8CowADnvdp+kQdYZWzAAw--.12181S2; Wed, 19 Oct 2016 23:30:15 +0800 (CST) From: Liping Zhang To: pablo@netfilter.org Cc: netfilter-devel@vger.kernel.org, Liping Zhang Subject: [PATCH nf-next] netfilter: nft_numgen: start round robin from zero Date: Wed, 19 Oct 2016 23:29:53 +0800 Message-Id: <1476890993-3518-1-git-send-email-zlpnobody@163.com> X-Mailer: git-send-email 2.5.5 X-CM-TRANSID: C8CowADnvdp+kQdYZWzAAw--.12181S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7Gw13ZFyrKFWDCF4kJw1rCrg_yoWfWrgEg3 97KrW3KFZ5Xr9xCws0vr47Zry7t3y5uF1fZryIvF4UAa4rGr1qy3ykWF1Fvr13W393Gry0 v34vyrn5K347WjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU0olk7UUUUU== X-Originating-IP: [180.170.252.41] X-CM-SenderInfo: x2os00perg5qqrwthudrp/xtbBZwcIl1etkhG+swAAsL Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org From: Liping Zhang Currently we start round robin from 1, but it's better to start round robin from 0. This is to keep consistent with xt_statistic in iptables. Signed-off-by: Liping Zhang --- net/netfilter/nft_numgen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/nft_numgen.c b/net/netfilter/nft_numgen.c index 55bc5ab..a66b360 100644 --- a/net/netfilter/nft_numgen.c +++ b/net/netfilter/nft_numgen.c @@ -65,7 +65,7 @@ static int nft_ng_inc_init(const struct nft_ctx *ctx, return -EOVERFLOW; priv->dreg = nft_parse_register(tb[NFTA_NG_DREG]); - atomic_set(&priv->counter, 0); + atomic_set(&priv->counter, priv->modulus - 1); return nft_validate_register_store(ctx, priv->dreg, NULL, NFT_DATA_VALUE, sizeof(u32));