From patchwork Tue Sep 20 02:31:04 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?6auY5bOw?= X-Patchwork-Id: 672056 X-Patchwork-Delegate: pablo@netfilter.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3sdRc10Nmhz9ryv for ; Tue, 20 Sep 2016 12:32:17 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753536AbcITCcF (ORCPT ); Mon, 19 Sep 2016 22:32:05 -0400 Received: from SMTPBG132.QQ.COM ([113.108.23.42]:56765 "EHLO smtpbg132.qq.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753530AbcITCcD (ORCPT ); Mon, 19 Sep 2016 22:32:03 -0400 X-QQ-mid: bizesmtp8t1474338672t8cbuve00 Received: from localhost.localdomain (unknown [123.56.230.35]) by esmtp4.qq.com (ESMTP) with id ; Tue, 20 Sep 2016 10:31:06 +0800 (CST) X-QQ-SSF: 01400000004000F0FG30000A0000000 X-QQ-FEAT: 9NFkmNiL4hcOE+c+XrDk7heYEf7H4LEcPwv59Gej9RbTLUt7K/YyzMIwKM80Y 2mCjjIWj2Nj/w9/+wi12lsK8GaO0tPjzHd7aUkUj9Xt3AT7YuVE3p1ysjqqO2H3DezBR2N9 NHk34FW9YdIXbaARNpsUYywzlADbMXgYCr1L8TpPKxFu+kDIbylpbBjLOmVzi2irawfMcNZ RMAArt8hWPrl5UtnGrB3ffKin3pRgF8xr0jtRgJ5dK2e/p/y5sKl4ToHUv2o1KcrmXTDX/k L4b3DBGe4GhTTa X-QQ-GoodBg: 2 From: fgao@ikuai8.com To: pablo@netfilter.org, netfilter-devel@vger.kernel.org Cc: gfree.wind@gmail.com, Gao Feng Subject: [PATCH nf-next] netfilter: xt_helper: Use sizeof(variable) instead of literal number Date: Tue, 20 Sep 2016 10:31:04 +0800 Message-Id: <1474338664-7258-1-git-send-email-fgao@ikuai8.com> X-Mailer: git-send-email 1.9.1 X-QQ-SENDSIZE: 520 Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org From: Gao Feng It's better to use sizeof(info->name)-1 as index to force set the string tail instead of literal number '29'. Signed-off-by: Gao Feng --- net/netfilter/xt_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/xt_helper.c b/net/netfilter/xt_helper.c index 9f4ab00..f71ee88 100644 --- a/net/netfilter/xt_helper.c +++ b/net/netfilter/xt_helper.c @@ -65,7 +65,7 @@ static int helper_mt_check(const struct xt_mtchk_param *par) par->family); return ret; } - info->name[29] = '\0'; + info->name[sizeof(info->name) - 1] = '\0'; return 0; }