| Message ID | 146183487873.3430.10556920470037312368.stgit@nfdev2.cica.es |
|---|---|
| State | Accepted |
| Delegated to: | Pablo Neira |
| Headers | show |
On Thu, Apr 28, 2016 at 11:14:38AM +0200, Arturo Borrero Gonzalez wrote: > If we include tests/ in the release tarball, downstream distributors > can run the testsuites themselves while developing the packages. > > This way, tests can be run in a more integrated environment and they can > discover errors related to the integration with the given distribution itself. > > Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com> > --- > Makefile.am | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Makefile.am b/Makefile.am > index 068009b..10aa40f 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -4,3 +4,5 @@ SUBDIRS = src \ > include \ > doc \ > files > + > +EXTRA_DIST = tests You can get a git clone instead? This is going to bloat the tarball for something that only a few developer need. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 28 April 2016 at 11:27, Pablo Neira Ayuso <pablo@netfilter.org> wrote: > On Thu, Apr 28, 2016 at 11:14:38AM +0200, Arturo Borrero Gonzalez wrote: >> If we include tests/ in the release tarball, downstream distributors >> can run the testsuites themselves while developing the packages. >> >> This way, tests can be run in a more integrated environment and they can >> discover errors related to the integration with the given distribution itself. >> >> Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com> >> --- >> Makefile.am | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Makefile.am b/Makefile.am >> index 068009b..10aa40f 100644 >> --- a/Makefile.am >> +++ b/Makefile.am >> @@ -4,3 +4,5 @@ SUBDIRS = src \ >> include \ >> doc \ >> files >> + >> +EXTRA_DIST = tests > > You can get a git clone instead? > > This is going to bloat the tarball for something that only a few > developer need. It seems these are the numbers: In the case of nftables * 327K withtout tests * 388K with tests In case of conntrack-tools * 496K without tests * 503K with tests I don't think this is a big deal. Other release tarballs include tests or qa files (libnftnl, ipset, libnetfilter-conntrack...)
On Thu, Apr 28, 2016 at 12:07:10PM +0200, Arturo Borrero Gonzalez wrote: > On 28 April 2016 at 11:27, Pablo Neira Ayuso <pablo@netfilter.org> wrote: > > On Thu, Apr 28, 2016 at 11:14:38AM +0200, Arturo Borrero Gonzalez wrote: > >> If we include tests/ in the release tarball, downstream distributors > >> can run the testsuites themselves while developing the packages. > >> > >> This way, tests can be run in a more integrated environment and they can > >> discover errors related to the integration with the given distribution itself. > >> > >> Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com> > >> --- > >> Makefile.am | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff --git a/Makefile.am b/Makefile.am > >> index 068009b..10aa40f 100644 > >> --- a/Makefile.am > >> +++ b/Makefile.am > >> @@ -4,3 +4,5 @@ SUBDIRS = src \ > >> include \ > >> doc \ > >> files > >> + > >> +EXTRA_DIST = tests > > > > You can get a git clone instead? > > > > This is going to bloat the tarball for something that only a few > > developer need. > > It seems these are the numbers: > > In the case of nftables > * 327K withtout tests > * 388K with tests > > In case of conntrack-tools > * 496K without tests > * 503K with tests > > I don't think this is a big deal. > > Other release tarballs include tests or qa files (libnftnl, ipset, > libnetfilter-conntrack...) Right, but libnftnl tests are self-contained (not kernel dependent). Anyway, nft tests are dependent of the kernel version, given that we've been augmenting the feature set along the nft development. So integrating this can be useful to you? -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 28 April 2016 at 14:20, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> So integrating this can be useful to you?
Yes, my plan is to launch the tests from the debian continuous
integration system.
On Thu, Apr 28, 2016 at 11:14:38AM +0200, Arturo Borrero Gonzalez wrote: > If we include tests/ in the release tarball, downstream distributors > can run the testsuites themselves while developing the packages. > > This way, tests can be run in a more integrated environment and they can > discover errors related to the integration with the given distribution itself. Applied. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Makefile.am b/Makefile.am index 068009b..10aa40f 100644 --- a/Makefile.am +++ b/Makefile.am @@ -4,3 +4,5 @@ SUBDIRS = src \ include \ doc \ files + +EXTRA_DIST = tests
If we include tests/ in the release tarball, downstream distributors can run the testsuites themselves while developing the packages. This way, tests can be run in a more integrated environment and they can discover errors related to the integration with the given distribution itself. Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com> --- Makefile.am | 2 ++ 1 file changed, 2 insertions(+) -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html