From patchwork Wed Apr 6 12:10:52 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arturo Borrero X-Patchwork-Id: 606960 X-Patchwork-Delegate: pablo@netfilter.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3qg4Lw3qR0z9t4F for ; Wed, 6 Apr 2016 22:11:04 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754082AbcDFMLD (ORCPT ); Wed, 6 Apr 2016 08:11:03 -0400 Received: from smtp3.cica.es ([150.214.5.190]:48235 "EHLO smtp.cica.es" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754237AbcDFMLC (ORCPT ); Wed, 6 Apr 2016 08:11:02 -0400 Received: from localhost (unknown [127.0.0.1]) by smtp.cica.es (Postfix) with ESMTP id F116251F22C; Wed, 6 Apr 2016 12:10:58 +0000 (UTC) X-Virus-Scanned: amavisd-new at cica.es Received: from smtp.cica.es ([127.0.0.1]) by localhost (mail.cica.es [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qSsOjpcyAEaO; Wed, 6 Apr 2016 14:10:53 +0200 (CEST) Received: from nfdev2.cica.es (nfdev2.cica.es [IPv6:2a00:9ac0:c1ca:31::221]) by smtp.cica.es (Postfix) with ESMTP id 7F37751F1F0; Wed, 6 Apr 2016 14:10:52 +0200 (CEST) Subject: [iptables PATCH] extensions/libxt_tcp: fix nftables translate flags value, 'none' vs '0x0' From: Arturo Borrero Gonzalez To: netfilter-devel@vger.kernel.org Cc: netfilter@mva.name Date: Wed, 06 Apr 2016 14:10:52 +0200 Message-ID: <145994465193.22717.2137088538000837721.stgit@nfdev2.cica.es> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org The iptables command: -m tcp --tcp-flags FIN,SYN,RST,PSH,ACK,URG NONE should translate to: tcp flags & fin|syn|rst|psh|ack|urg == 0x0 instead of: tcp flags & fin|syn|rst|psh|ack|urg == none Reported-by: Vadim A. Misbakh-Soloviov Signed-off-by: Arturo Borrero Gonzalez Tested-by: Vadim A. Misbakh-Soloviov --- extensions/libxt_tcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/extensions/libxt_tcp.c b/extensions/libxt_tcp.c index 6a85ed4..2a14035 100644 --- a/extensions/libxt_tcp.c +++ b/extensions/libxt_tcp.c @@ -390,7 +390,7 @@ static void print_tcp_xlate(struct xt_xlate *xl, uint8_t flags) } if (!have_flag) - xt_xlate_add(xl, "none"); + xt_xlate_add(xl, "0x0"); } static int tcp_xlate(const void *ip, const struct xt_entry_match *match,